maintenance

Moved global variables to locals
deleted unused content
whitespace (preparation)

Author: SteelBlueZK

LuaUI/Widgets/gui_reclaiminfo.lua

@@ -36,7 +36,7 @@ local rangeend = {}  --counting radius end point
 local b1was = false  -- cursor was outside the map?
 local vsx, vsy = widgetHandler:GetViewSizes()
 local form = 12 --text format depends on screen size
-local xstart,ystart = 0
+local xstart,ystart = 0, 0
 local cmd,xend,yend,x,y,b1,b2
 local inMinimap = false --mouse cursor in minimap
 

LuaUI/Widgets/unit_smart_nanos.lua

@@ -26,23 +26,23 @@ end
 --------------------------------------------------------------------------------
 --------------------------------------------------------------------------------
 
-local GetUnitDefID        = Spring.GetUnitDefID
-local GetAllUnits         = Spring.GetAllUnits
-local GetMyTeamID         = Spring.GetMyTeamID
-local GetUnitNearestEnemy = Spring.GetUnitNearestEnemy
-local GiveOrderToUnit     = Spring.GiveOrderToUnit
-local GetUnitHealth       = Spring.GetUnitHealth
-local GetUnitsInCylinder  = Spring.GetUnitsInCylinder
-local GetUnitPosition     = Spring.GetUnitPosition
-local GetUnitCommandCount = Spring.GetUnitCommandCount
-local GetFeatureDefID     = Spring.GetFeatureDefID
-local GetFeatureResources = Spring.GetFeatureResources
-local AreTeamsAllied      = Spring.AreTeamsAllied
-local GetFeaturePosition  = Spring.GetFeaturePosition
-local GetGameSeconds      = Spring.GetGameSeconds
-local GetSelectedUnits    = Spring.GetSelectedUnits
-local GetUnitTeam         = Spring.GetUnitTeam
-local GetTeamResources    = Spring.GetTeamResources
+local GetUnitDefID            = Spring.GetUnitDefID
+local GetAllUnits             = Spring.GetAllUnits
+local GetMyTeamID             = Spring.GetMyTeamID
+local GetUnitNearestEnemy     = Spring.GetUnitNearestEnemy
+local GiveOrderToUnit         = Spring.GiveOrderToUnit
+local GetUnitHealth           = Spring.GetUnitHealth
+local GetUnitsInCylinder      = Spring.GetUnitsInCylinder
+local GetUnitPosition         = Spring.GetUnitPosition
+local GetUnitCommandCount     = Spring.GetUnitCommandCount
+local GetFeatureDefID         = Spring.GetFeatureDefID
+local GetFeatureResources     = Spring.GetFeatureResources
+local AreTeamsAllied          = Spring.AreTeamsAllied
+local GetFeaturePosition      = Spring.GetFeaturePosition
+local GetGameSeconds          = Spring.GetGameSeconds
+local GetSelectedUnits        = Spring.GetSelectedUnits
+local GetUnitTeam             = Spring.GetUnitTeam
+local GetTeamResources        = Spring.GetTeamResources
 
 --------------------------------------------------------------------------------
 --------------------------------------------------------------------------------
@@ -155,7 +155,7 @@ function widget:CommandNotify(id, params, options)
 	end
 
 	if (id == CMD.RECLAIM) then
-		targetUnit = params[1]
+		local targetUnit = params[1]
 		teamUnits[targetUnit] = nil
 		for unitID,unitDefs in pairs(nanoTurrets) do
 			local cmdID, _, _, cmdParam = Spring.GetUnitCurrentCommand(unitID)
@@ -170,7 +170,7 @@ function widget:CommandNotify(id, params, options)
 	end
 
 	if (id == CMD.REPAIR) then
-		targetUnit = params[1]
+		local targetUnit = params[1]
 		if (not teamUnits[targetUnit]) and (not allyUnits[targetUnit]) and (not nanoTurrets[targetUnit])
 				and (not buildUnits[targetUnit]) and (GetUnitTeam(targetUnit) == myTeamID) then
 			widget:UnitFinished(targetUnit, GetUnitDefID(targetUnit), myTeamID)

effects/roach.lua

@@ -40,16 +40,6 @@ return {
     },
   },
   blastwing = {
-    groundflash = {
-      flashalpha         = 1,
-      flashsize          = 108,
-      ttl                = 75,
-      color = {
-        [1]  = 0.7,
-        [2]  = 0.3,
-        [3]  = 0.1,
-      },
-    },
     redploom = {
       air                = true,
       class              = [[CExpGenSpawner]],

lups/lups.lua

@@ -921,7 +921,7 @@ local function GameFrame(_,n)
 	CleanInvalidUnitFX()
 
 	--// update FXs
-	framesToUpdate = thisGameFrame - lastGameFrame
+	local framesToUpdate = thisGameFrame - lastGameFrame
 	for _,partFx in pairs(particles) do
 		if (n>=partFx.dieGameFrame) then
 			--// lifetime ended