prevent ambiguous operator overload resolution for Result

liam-teale · liam-teale · commit 4d63f225d8c2 · 2025-08-26T16:04:35.000-07:00
diff --git a/include/common/result.hpp b/include/common/result.hpp
@@ -142,6 +142,9 @@ class Result {
     constexpr bool contains(E error) {
         return this->error == error;
     }
+
+    // prevent ambiguous operator overload resolution
+    bool operator==(const Result& other) = delete;
 };
 
 } // namespace zest

Original file line number	Diff line number	Diff line change
`@@ -142,6 +142,9 @@ class Result {`
`142`	`142`	`constexpr bool contains(E error) {`
`143`	`143`	`return this->error == error;`
`144`	`144`	`}`
	`145`	`+`
	`146`	`+ // prevent ambiguous operator overload resolution`
	`147`	`+ bool operator==(const Result& other) = delete;`
`145`	`148`	`};`
`146`	`149`
`147`	`150`	`} // namespace zest`