feat(demo): show loading overlay during large diff preparation#8
Merged
Zhang-JiahangH merged 1 commit intomainfrom Apr 7, 2026
Merged
feat(demo): show loading overlay during large diff preparation#8Zhang-JiahangH merged 1 commit intomainfrom
Zhang-JiahangH merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
useMemointo an effect-driven flow usinguseEffect+setTimeout(0)so the UI can render a loading state before heavy computation runs.isPreparingstate and initializediffDataviauseStateto allow controlled updates and to keep the viewer mounted while new data is prepared.isPreparingis true..viewer-loading--overlay) to position and style the loading state (semi-transparent background and blur).Testing
pnpm --filter demo buildin the environment, which failed due to missing/unalikeable dev workspace dependencies (e.g.react-router-domand workspace package resolution), so a full production build could not be validated here.Codex Task