FIX: Add scikit-learn >= 1.6.0 compatibility for _validate_data#41
Open
J4nvg wants to merge 1 commit into
Open
FIX: Add scikit-learn >= 1.6.0 compatibility for _validate_data#41J4nvg wants to merge 1 commit into
J4nvg wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Issue
Users installing
imbalanced-ensemblealongsidescikit-learn >= 1.6.0encounter anAttributeErrorwhen calling.fit()on ensemble classifiers (e.g.,SelfPacedEnsembleClassifier).This happens because
scikit-learnversion 1.6.0 removed the private_validate_datamethod from theBaseEstimatorclass and moved it to a public standalone utility function (sklearn.utils.validation.validate_data).The Solution
This PR introduces a backward-compatible bridge in
imbens/ensemble/base.pyto handle the version difference dynamically without breaking older setups.try/exceptblock to safely importvalidate_datafromsklearn.utils.validationif it exists._validate_datainBaseImbalancedEnsembleto act as a routing method:scikit-learn >= 1.6.0, it passes the arguments to the new utility function.scikit-learn < 1.6.0, it falls back tosuper()._validate_data().Testing
AttributeErroris resolved when running withscikit-learn==1.6.0.pytestsuite. All core ensemble tests pass successfully, confirming that the fallback preserves behavior for existing logic.