test: address PR review feedback on rig + connector test guards

- in_scope defaults False on CriticalPathStatus so a future evaluate()
  regression that forgets it under-gates (warning) rather than over-gates
  (spurious build block). [greptile]
- widen connector integration skip guards (redshift, snowflake, gdrive,
  minio, pcs) to require every env var the test hard-references, so a
  partially configured env skips cleanly instead of failing. [coderabbit]
- usage_v2 test_helper: swap Usage via an autouse monkeypatch fixture
  instead of a module-level rebind that leaks FakeUsage into later tests.
- build_index_payload test: evict the helper module from sys.modules after
  binding it, so later importers in the same process get a real copy.
- drop dead tox `runner` alias (its unit-runner group was removed).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01C5HQX5CSoMR6RzHtXcfwJt

Author: chandrasekharan-zipstack

backend/prompt_studio/prompt_studio_core_v2/tests/test_build_index_payload.py

@@ -94,6 +94,12 @@ def _restore_modules() -> None:
         else:
             sys.modules[name] = original
     _SAVED_MODULES.clear()
+    # The helper imported above is now cached bound to the stubbed globals.
+    # Evict it so any later importer in this process gets a real copy; our
+    # own `_psh_mod`/`PromptStudioHelper` refs are already bound, unaffected.
+    sys.modules.pop(
+        "prompt_studio.prompt_studio_core_v2.prompt_studio_helper", None
+    )
 
 
 try:

backend/usage_v2/tests/test_helper.py

@@ -17,6 +17,7 @@
 from typing import Any
 from unittest.mock import MagicMock
 
+import pytest
 import usage_v2.helper as helper_mod
 from usage_v2.helper import UsageHelper
 
@@ -26,8 +27,12 @@ class FakeUsage:
     objects = MagicMock(name="Usage.objects")
 
 
-# Swap the symbol get_usage_by_model resolves; leaves the real model untouched.
-helper_mod.Usage = FakeUsage
+@pytest.fixture(autouse=True)
+def _swap_usage(monkeypatch: pytest.MonkeyPatch) -> None:
+    # Swap the symbol get_usage_by_model resolves, per-test, so monkeypatch
+    # restores the real model afterwards — a module-level rebind would leak
+    # FakeUsage into every later test in the same process.
+    monkeypatch.setattr(helper_mod, "Usage", FakeUsage)
 
 
 # ---------------------------------------------------------------------------

tests/rig/critical_paths.py

@@ -67,8 +67,10 @@ class CriticalPathStatus:
     notes: str = ""
     # True when a declared covering group belongs to the tier(s) this run
     # covered. An out-of-scope gap (coverage only in an unrun tier, or none
-    # declared) must not gate under --fail-on-critical-gap.
-    in_scope: bool = True
+    # declared) must not gate under --fail-on-critical-gap. Defaults False so a
+    # regression that forgets to pass it can only under-gate (spurious warning),
+    # never over-gate (spurious build block).
+    in_scope: bool = False
 
     def __post_init__(self) -> None:
         # Make the contradictory states unrepresentable rather than relying on

tox.ini

@@ -69,8 +69,5 @@ commands = python -m tests.rig {posargs:list-groups}
 # These mirror the pre-rig envs so existing scripts / CI snippets keep working
 # during the migration. They delegate to the corresponding rig group.
 
-[testenv:runner]
-commands = python -m tests.rig run unit-runner {posargs}
-
 [testenv:sdk1]
 commands = python -m tests.rig run unit-sdk1 {posargs}

unstract/connectors/tests/databases/test_redshift_db.py

@@ -6,7 +6,7 @@
 
 class TestRedshift(unittest.TestCase):
     @unittest.skipUnless(
-        os.environ.get("REDSHIFT_TEST_PASSWORD"),
+        os.environ.get("REDSHIFT_TEST_PASSWORD") and os.environ.get("REDSHIFT_TEST_HOST"),
         "Integration test requires a live Redshift cluster and REDSHIFT_TEST_* env vars",
     )
     def test_user_name_and_password(self):

unstract/connectors/tests/databases/test_snowflake_db.py

@@ -6,7 +6,9 @@
 
 class TestSnowflakeDB(unittest.TestCase):
     @unittest.skipUnless(
-        os.environ.get("SNOWFLAKE_TEST_PASSWORD"),
+        os.environ.get("SNOWFLAKE_TEST_PASSWORD")
+        and os.environ.get("SNOWFLAKE_TEST_USER")
+        and os.environ.get("SNOWFLAKE_TEST_ACCOUNT"),
         "Integration test requires a live Snowflake account and SNOWFLAKE_TEST_* env vars",
     )
     def test_something(self):

unstract/connectors/tests/filesystems/test_google_drive_fs.py

@@ -6,8 +6,9 @@
 
 class TestGoogleDriveFS(unittest.TestCase):
     @unittest.skipUnless(
-        os.environ.get("GDRIVE_GOOGLE_SERVICE_ACCOUNT"),
-        "Integration test requires GDRIVE_GOOGLE_SERVICE_ACCOUNT",
+        os.environ.get("GDRIVE_GOOGLE_SERVICE_ACCOUNT")
+        and os.environ.get("GDRIVE_GOOGLE_PROJECT_ID"),
+        "Integration test requires GDRIVE_GOOGLE_SERVICE_ACCOUNT and GDRIVE_GOOGLE_PROJECT_ID",
     )
     def test_basic(self):
         self.assertEqual(GoogleDriveFS.requires_oauth(), True)

unstract/connectors/tests/filesystems/test_miniofs.py

@@ -33,8 +33,9 @@ def test_s3(self) -> None:
         print(s3.get_fsspec_fs().ls("unstract-user-storage"))
 
     @unittest.skipUnless(
-        os.environ.get("MINIO_ACCESS_KEY_ID"),
-        "Integration test requires a live MinIO and MINIO_ACCESS_KEY_ID",
+        os.environ.get("MINIO_ACCESS_KEY_ID")
+        and os.environ.get("MINIO_SECRET_ACCESS_KEY"),
+        "Integration test requires a live MinIO and MINIO_ACCESS_KEY_ID + MINIO_SECRET_ACCESS_KEY",
     )
     def test_minio(self) -> None:
         self.assertEqual(MinioFS.requires_oauth(), False)

unstract/connectors/tests/filesystems/test_pcs.py

@@ -6,8 +6,9 @@
 
 class TestPCS_FS(unittest.TestCase):
     @unittest.skipUnless(
-        os.environ.get("GOOGLE_STORAGE_ACCESS_KEY_ID"),
-        "Integration test requires GOOGLE_STORAGE_ACCESS_KEY_ID",
+        os.environ.get("GOOGLE_STORAGE_ACCESS_KEY_ID")
+        and os.environ.get("GOOGLE_STORAGE_SECRET_ACCESS_KEY"),
+        "Integration test requires GOOGLE_STORAGE_ACCESS_KEY_ID and GOOGLE_STORAGE_SECRET_ACCESS_KEY",
     )
     def test_pcs(self) -> None:
         self.assertEqual(UnstractCloudStorage.requires_oauth(), False)