Skip to content

UN-3185: Fix squished route-loading spinner in the content area #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaseemjaskp merged 1 commit into from
Jun 26, 2026
+27 −1
Merged

UN-3185: Fix squished route-loading spinner in the content area #2118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions frontend/src/components/error/LazyOutlet/LazyOutlet.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* Center the route-loading fallback in the content area. */
.lazyOutletFallback {
display: flex;
width: 100%;
min-height: 60vh;
align-items: center;
justify-content: center;
}

/* GenericLoader's .center uses `width/height: inherit`, which collapses to a
narrow column inside the flex content area (the loader text ends up wrapping
one word per line next to the sidebar). Pin it to the full fallback width so
it renders centered at its natural size instead. */
.lazyOutletFallback > .center {
width: 100%;
height: auto;
}
11 changes: 10 additions & 1 deletion frontend/src/components/error/LazyOutlet/LazyOutlet.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Outlet, useLocation } from "react-router-dom";

import { GenericLoader } from "../../generic-loader/GenericLoader.jsx";
import { ErrorBoundary } from "../../widgets/error-boundary/ErrorBoundary.jsx";
import "./LazyOutlet.css";

// A failed dynamic import — almost always a stale hashed chunk after a
// redeploy (the client's index.html references a filename the CDN no longer
Expand Down Expand Up @@ -74,7 +75,15 @@ export function LazyOutlet() {
onError={handleRouteError}
fallbackComponent={<RouteLoadError />}
>
<Suspense fallback={<GenericLoader />}>
{/* Wrap the loader so it fills the content area and stays centered — see
LazyOutlet.css for why GenericLoader needs this here. */}
<Suspense
fallback={
<div className="lazyOutletFallback">
<GenericLoader />
</div>
}
>
<Outlet />
</Suspense>
</ErrorBoundary>
Expand Down