Commit 13ccd7a
fix: address reviewer feedback — next_run_time, null guards, stale closure
P1: _compute_next_run_time added remaining to reference (last_run_at)
instead of now, giving wrong results for interval jobs. Fixed to
use timezone.now() + remaining. Added logger.debug on failure.
P1: getTooltipText crashed when a job had no linked periodic task.
Guarded with optional chaining on periodic_task_details.
P2: Auto-expand useEffect used JobHistoryData as dep, resetting
user-expanded rows on every filter change. Switched to backUpData
so it only fires on fresh data loads.
P2: handleJobChange useCallback was missing getRunHistoryList in its
dependency array, risking stale closure. Added to deps.
Nit: Added RUNNING key to STATUS_META so backends that send RUNNING
instead of STARTED render correctly.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent ad1faaa commit 13ccd7a
2 files changed
Lines changed: 19 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
147 | 150 | | |
148 | 151 | | |
149 | 152 | | |
| |||
180 | 183 | | |
181 | 184 | | |
182 | 185 | | |
183 | | - | |
| 186 | + | |
184 | 187 | | |
185 | | - | |
| 188 | + | |
186 | 189 | | |
187 | 190 | | |
188 | 191 | | |
189 | | - | |
| 192 | + | |
190 | 193 | | |
191 | 194 | | |
192 | 195 | | |
| |||
203 | 206 | | |
204 | 207 | | |
205 | 208 | | |
206 | | - | |
| 209 | + | |
207 | 210 | | |
208 | 211 | | |
209 | 212 | | |
| |||
332 | 335 | | |
333 | 336 | | |
334 | 337 | | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
335 | 344 | | |
336 | 345 | | |
337 | 346 | | |
| |||
0 commit comments