fix: address Greptile review — name lookup safety, seed schema, field names

P1: Connection name-lookup before delete could block deletion on
    transient errors. Wrapped in try/except so deletion proceeds
    regardless; event falls back to connection_id.

P2: SeedCompleted failure path had schema_name="". Now reads from
    self.context.schema_name with fallback to empty string.

P2: Renamed misleading proto fields — connection_id → connection_name
    and environment_id → environment_name since they carry display
    names, not UUIDs. Updated event classes and all callers.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: abhizipstack

backend/backend/core/routers/connection/views.py

@@ -121,10 +121,14 @@ def connection_usage(request: Request, connection_id: str) -> Response:
 @handle_permission
 def delete_connection(request: Request, connection_id: str) -> Response:
     con_context = ConnectionContext()
-    conn_data = con_context.get_connection(connection_id=connection_id)
-    conn_name = conn_data.get("name", connection_id) if conn_data else connection_id
+    conn_name = connection_id
+    try:
+        conn_data = con_context.get_connection(connection_id=connection_id)
+        conn_name = conn_data.get("name", connection_id) if conn_data else connection_id
+    except Exception:
+        pass  # Best-effort name lookup; deletion proceeds regardless
     con_context.delete_connection(connection_id=connection_id)
-    fire_event(ConnectionDeletedEvt(connection_id=conn_name))
+    fire_event(ConnectionDeletedEvt(connection_name=conn_name))
     response_data = {
         "status": "success",
         "data": f"{connection_id} is deleted successfully.",

backend/backend/core/routers/environment/views.py

@@ -100,7 +100,7 @@ def delete_environment(request: Request, environment_id: str):
             job_names=", ".join(job_names) if job_names else "unknown",
         )
 
-    fire_event(EnvironmentDeleted(environment_id=env_name))
+    fire_event(EnvironmentDeleted(environment_name=env_name))
     response_data = {"status": "success"}
     return Response(data=response_data, status=status.HTTP_200_OK)
 

backend/visitran/events/proto_types.py

@@ -986,7 +986,7 @@ def code(self) -> str:
         return "U017"
 
     def message(self) -> str:
-        return f'Connection "{self.connection_id}" deleted'
+        return f'Connection "{self.connection_name}" deleted'
 
 
 @dataclass
@@ -1004,4 +1004,4 @@ def code(self) -> str:
         return "U019"
 
     def message(self) -> str:
-        return f'Environment "{self.environment_id}" deleted'
+        return f'Environment "{self.environment_name}" deleted'

backend/visitran/events/types.py

@@ -865,7 +865,9 @@ def validate_and_run_seed(self, seed_file, session_id: str) -> dict[str, str]:
             # Catches all kind of errors and raises with custom exceptions for seeds
             fire_event(SeedExecutionError(file_name, str(err)))
             fire_event(SeedCompleted(
-                seed_name=file_name, schema_name="", status="Failed",
+                seed_name=file_name,
+                schema_name=getattr(self.context, "schema_name", "") or "",
+                status="Failed",
             ))
             logging.exception(f"validate and run seed failed with exception {err}")
             raise RunSeedFailedException(file_name=file_name, error_message=str(err))