Commit 8e49a74
fix: address Greptile review — null env, stale cache, deps, DB filter
P1: list_deploy_candidates crashed with AttributeError when a task had
no environment. Guard with `if env else ""` (same pattern used in
list_recent_runs_for_model).
P2: list_deploy_candidates loaded all project tasks and filtered in
Python. Added model_configs__has_key=model_name to the queryset so
the DB does the heavy lifting.
P2: Recent-runs popup showed stale data after a Quick Deploy because
fetchedFor wasn't cleared. Now reset to null after successful
dispatch so the next dropdown open refetches.
P2: getRunTriggerScope was defined inside the Runhistory component,
triggering react-hooks/exhaustive-deps warnings and unnecessary
re-creation. Moved to module scope — it has no dependency on
component state.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>1 parent e40207d commit 8e49a74
3 files changed
Lines changed: 19 additions & 18 deletions
File tree
- backend/backend/core/scheduler
- frontend/src/ide
- editor/no-code-model
- run-history
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
766 | 766 | | |
767 | 767 | | |
768 | 768 | | |
| 769 | + | |
769 | 770 | | |
770 | 771 | | |
771 | 772 | | |
772 | 773 | | |
773 | 774 | | |
774 | 775 | | |
775 | | - | |
776 | | - | |
777 | | - | |
| 776 | + | |
778 | 777 | | |
779 | 778 | | |
780 | 779 | | |
781 | 780 | | |
782 | 781 | | |
783 | 782 | | |
| 783 | + | |
784 | 784 | | |
785 | 785 | | |
786 | 786 | | |
787 | | - | |
788 | | - | |
789 | | - | |
790 | | - | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
791 | 792 | | |
792 | 793 | | |
793 | 794 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1803 | 1803 | | |
1804 | 1804 | | |
1805 | 1805 | | |
| 1806 | + | |
1806 | 1807 | | |
1807 | 1808 | | |
1808 | 1809 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
64 | 74 | | |
65 | 75 | | |
66 | 76 | | |
| |||
83 | 93 | | |
84 | 94 | | |
85 | 95 | | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | 96 | | |
98 | 97 | | |
99 | 98 | | |
| |||
0 commit comments