Skip to content

Commit c1c84f2

Browse files
tahierhussainclaude
andcommitted
fix(claude): run secrets scan on already-committed path
Edge case "no uncommitted changes" previously said to skip Phases 1-4 wholesale, which silently bypassed the secrets-scan hard stop in Phase 1 and contradicted the Section 8 guardrail. Now the scan still runs against `git diff <base>...HEAD` on this path; only the commit-planning steps (Phases 2-3) are skipped if the scan comes back clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 2977143 commit c1c84f2

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

.claude/skills/ship/SKILL.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,12 @@ Classify the work as **feature** or **non-feature**:
7676
**Edge cases:**
7777
- Already on a feature branch (not `main`/`master`/`develop`) → ask whether to continue
7878
committing on it or branch off
79-
- **No uncommitted changes (everything already committed locally)** → skip Phases 1–4;
80-
derive the branch name and PR description from existing commit messages and
81-
`git diff <base>...HEAD`; push existing commits in Phase 4; proceed to Phase 5
79+
- **No uncommitted changes (everything already committed locally)** → run the
80+
secrets scan below against `git diff <base>...HEAD` first (same hard-stop
81+
rules apply — local commits can leak secrets just as easily as uncommitted
82+
diffs). If clean, skip commit-planning (Phases 2–3); derive the branch name
83+
and PR description from existing commit messages and `git diff <base>...HEAD`;
84+
push existing commits in Phase 4; proceed to Phase 5.
8285
- Branch already pushed → skip the Phase 4 push step
8386
- On `main`/`master`/`develop` with **no changes at all** → stop with a clear message
8487
- Diff spans clearly unrelated areas → stop and ask whether to split

0 commit comments

Comments
 (0)