-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add CODEOWNERS for automated review routing #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||||||||||
| # Default — all PRs require review from L1 reviewers | ||||||||||||||
| * @Zipstack/visitran-reviewers-l1 | ||||||||||||||
|
|
||||||||||||||
| # Backend | ||||||||||||||
| /backend/ @Zipstack/visitran-reviewers-l1 @Zipstack/visitran-reviewers-l2 | ||||||||||||||
|
|
||||||||||||||
| # Frontend | ||||||||||||||
| /frontend/ @Zipstack/visitran-reviewers-l1 | ||||||||||||||
|
|
||||||||||||||
| # Core library | ||||||||||||||
| /visitran/ @Zipstack/visitran-reviewers-l2 | ||||||||||||||
|
|
||||||||||||||
| # Tests | ||||||||||||||
| /tests/ @Zipstack/visitran-reviewers-l1 | ||||||||||||||
|
|
||||||||||||||
| # CI/CD and infrastructure | ||||||||||||||
| /.github/ @Zipstack/visitran-admins | ||||||||||||||
| /docker/ @Zipstack/visitran-admins | ||||||||||||||
|
Comment on lines
+17
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The
Suggested change
Prompt To Fix With AIThis is a comment left during a code review.
Path: .github/CODEOWNERS
Line: 17-18
Comment:
**`ci/` directory not covered by admin rule**
The `ci/` directory exists at the repo root and contains pipeline scripts (notably `increment_version.py`). It has no explicit rule and silently falls back to the `*` catch-all — routing reviews to L1 only. Since `/.github/` and `/docker/` are both explicitly assigned to `@Zipstack/visitran-admins` due to their infrastructure nature, `ci/` should receive the same treatment for consistency:
```suggestion
# CI/CD and infrastructure
/.github/ @Zipstack/visitran-admins
/docker/ @Zipstack/visitran-admins
/ci/ @Zipstack/visitran-admins
```
How can I resolve this? If you propose a fix, please make it concise. |
||||||||||||||
|
|
||||||||||||||
| # Documentation | ||||||||||||||
| /*.md @Zipstack/visitran-reviewers-l1 | ||||||||||||||
abhizipstack marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||||||||
| /docs/ @Zipstack/visitran-reviewers-l1 | ||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.