Upgrade hyper to 1.x#3
Open
SplittyDev wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces significant internal code changes in order to upgrade
hyperfrom0.xto1.x.In my opinion, these changes are not at all easy to understand, and I have serious doubts about their correctness. I don't know why the original author chose to use
hyperfor this instead of building on a more abstract and developer-friendly library such asreqwest, but here we are.. Going fromhypertoreqwestwould probably touch a lot more of the public-facing API and require even more extensive internal changes, and I really don't want to do that any time soon.These changes will have to be extensively tested before considering merging this.
Right now all tests are succeeding, but we should test the change in
hdropto be sure.Major Changes
httpdependency (0.2 -> 1.1)hyperdependency (0.x -> 1.x)hyper::Urivsurl::Urlsigning::tests::test_path_encodesigning::tests::test_path_slash_encodeMinor Changes
hyper-utildependencyhttp-body-utildependencyquick-xmldependency (0.29 -> 0.31)strum-macrosdependency (0.25 -> 0.26)base64dependency (0.21 -> 0.22)env_loggerdependency (0.10 -> 0.11)hyper-tlsdependency (deprecated)resolverversion2denyconfig to version2