Fix: Avoid endless AJAX table update requests if the query returned 0 rows on the Log page.#4838
Merged
Merged
Conversation
… on the Log page. (log.js)
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an infinite AJAX refresh loop on the Classic skin Log page when the server returns zero log rows, by preventing bootstrap-table from repeatedly forcing a page change.
Changes:
- Disabled the
bootstrapTable('selectPage', 1)call that was triggering repeated AJAX refreshes whendata.rows.length === 0. - Added inline comments explaining why the page-reset code was removed and referencing prior pagination work.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@connortechnology |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@connortechnology |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #4826