Skip to content

Fix: Avoid endless AJAX table update requests if the query returned 0 rows on the Log page. #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortechnology merged 4 commits into from
May 21, 2026
Merged

Fix: Avoid endless AJAX table update requests if the query returned 0 rows on the Log page. #4838

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
26f2d81
Avoid endless AJAX table update requests if the query returned 0 rows…
IgorA100 May 16, 2026
dcf03c8
More accurate page navigation and statistics display (log.js)
IgorA100 May 17, 2026
a01f196
Potential fix for pull request finding
IgorA100 May 20, 2026
27d196a
Edited comment (log.js)
IgorA100 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions web/skins/classic/views/js/log.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,10 @@ function ajaxRequest(params) {
data: params.data,
timeout: 0,
success: function(data) {
if (!data.rows.length) {
// If page is > 1, bt infinitely loops
if (!data.rows.length && data.total > 0) {
// The requested page is out of range; reset to page 1.
table.bootstrapTable('selectPage', 1);
return;
}
// rearrange the result into what bootstrap-table expects
params.success({
Expand Down Expand Up @@ -93,8 +94,8 @@ function filterLog() {
function updateHeaderStats(data) {
var pageNum = table.bootstrapTable('getOptions').pageNumber;
var pageSize = table.bootstrapTable('getOptions').pageSize;
var startRow = ( (pageNum - 1 ) * pageSize ) + 1;
var stopRow = pageNum * pageSize;
var startRow = (data.total > 0) ? (( (pageNum - 1 ) * pageSize ) + 1) : 0;
var stopRow = (data.total > 0) ? Math.min(data.total, pageNum * pageSize) : 0;
var newClass = (data.logstate == 'ok') ? 'text-success' : (data.logstate == 'alert' ? 'text-warning' : ((data.logstate == 'alarm' ? 'text-danger' : '')));

$j('#logState').text(data.logstate);
Expand Down
Loading