Slightly sped up DOM rendering when switching monitors on Watch page#4884
Open
IgorA100 wants to merge 1 commit into
Open
Slightly sped up DOM rendering when switching monitors on Watch page#4884IgorA100 wants to merge 1 commit into
IgorA100 wants to merge 1 commit into
Conversation
Clearing via textContent is performed without page parsing, which speeds up cleanup. When executing innerHTML, clearing will first occur by parsing the page, and then assigning new elements. This will slightly speed up DOM rendering by quickly clearing.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to speed up UI updates on the Watch page when switching monitors by clearing the main monitor container before injecting new stream markup.
Changes:
- Clears the
#monitorelement viatextContent = ''before settinginnerHTMLto the new monitor’sstreamHTML.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
946
to
948
| //Change main monitor block | ||
| monitor_div.textContent = ''; | ||
| monitor_div.innerHTML = currentMonitor.streamHTML; |
Member
|
copilot doesn't like your change. I'm not sure. I'm a little surprised that that would give any noticeable speed increase. Would be nice if we could just say turn off dom updates until we are ready to redraw.... maybe there is a way. I just don't know it. github has gotten stupid about copilot billing. I'm going to integrate my paid Claude subscription instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing via
textContentis performed without page parsing, which speeds up cleanup.When executing
innerHTML, clearing will first occur by parsing the page, and then assigning new elements.This will slightly speed up DOM rendering by quickly clearing.