Prevent pointless setInterval(this.statusCmdQuery) calls for "frozen"objects. (MonitorStream.js)#4887
Open
IgorA100 wants to merge 2 commits into
Open
Prevent pointless setInterval(this.statusCmdQuery) calls for "frozen"objects. (MonitorStream.js)#4887IgorA100 wants to merge 2 commits into
IgorA100 wants to merge 2 commits into
Conversation
… objects. (MonitorStream.js) This PR doesn't fix the root cause of the issue, but addresses the consequences. I spent time investigating the problem, but I couldn't figure out the root cause because it's difficult to debug. Perhaps I'll revisit this issue later. For now, let's leave it at that.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to mitigate a Watch-page issue where statusCmdQuery continues to run on stale (“frozen”) MonitorStream instances (not fixing the underlying root cause), by adding a guard in MonitorStream.statusCmdQuery for go2rtc streams.
Changes:
- Added a
currentModeguard in the go2rtc branch ofstatusCmdQuery. - When the guard triggers, attempts to stop further polling by clearing
this.statusCmdTimerand returning early.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Please recheck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't fix the root cause of the issue, but addresses the consequences. I spent time investigating the problem, but I couldn't figure out the root cause because it's difficult to debug. Perhaps I'll revisit this issue later.
For now, let's leave it at that.