Skip to content

Commit 0801635

Browse files
fix(ThinkingBudget): extract maxOutputTokensControl to resolve undefined reference in binary reasoning path
1 parent b761a0a commit 0801635

1 file changed

Lines changed: 22 additions & 0 deletions

File tree

webview-ui/src/components/settings/ThinkingBudget.tsx

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,27 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
164164
return null
165165
}
166166

167+
// Max output tokens control used by both binary reasoning and budget reasoning paths.
168+
const maxOutputTokensControl = (
169+
<div className="flex flex-col gap-1">
170+
<div className="font-medium">{t("settings:thinkingBudget.maxTokens")}</div>
171+
<div className="flex items-center gap-1">
172+
<Slider
173+
min={8192}
174+
max={Math.max(
175+
modelInfo.maxTokens || 8192,
176+
customMaxOutputTokens,
177+
DEFAULT_HYBRID_REASONING_MODEL_MAX_TOKENS,
178+
)}
179+
step={1024}
180+
value={[customMaxOutputTokens]}
181+
onValueChange={([value]) => setApiConfigurationField("modelMaxTokens", value)}
182+
/>
183+
<div className="w-12 text-sm text-center">{customMaxOutputTokens}</div>
184+
</div>
185+
</div>
186+
)
187+
167188
// Models with supportsReasoningBinary (binary reasoning) show a simple on/off toggle
168189
if (isReasoningSupported) {
169190
return (
@@ -175,6 +196,7 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
175196
}>
176197
{t("settings:providers.useReasoning")}
177198
</Checkbox>
199+
{maxOutputTokensControl}
178200
</div>
179201
)
180202
}

0 commit comments

Comments
 (0)