Commit 12e6b9c
committed
fix: address review feedback on ripgrep diagnostic command
- diagnostic.ts: fix .asar->.asar.unpacked regex (the \b boundary was
matching inside node_modules.asar.unpacked too, producing
.unpacked.unpacked). Replaced with a path-separator lookahead.
- diagnostic.ts: create the OutputChannel once at registration and
return a composite Disposable that disposes both the command and
the channel; clear the channel before appending so repeated runs
are readable.
- diagnostic.ts: route the command ID through getCommand() instead
of hardcoding 'zoo-code.showRipgrepDiagnostic', and add
'showRipgrepDiagnostic' to the CommandId union in @roo-code/types.
Exclude it from getCommandsMap so the diagnostic's separate
registration owns the OutputChannel lifecycle.
- package.json + package.nls.*.json: switch the command title to a
%command.showRipgrepDiagnostic.title% NLS key across all 18 locale
files.
- loadRipgrep.ts: preserve the require() error message in a
loadError field instead of swallowing it; surface it in the
diagnostic report.
- Tests updated for the loadError case, the already-unpacked path
guard, and widened the mock value type.1 parent dcb043c commit 12e6b9c
24 files changed
Lines changed: 81 additions & 12 deletions
File tree
- packages/types/src
- src
- activate
- services/ripgrep
- __tests__
- internal
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
77 | 85 | | |
78 | 86 | | |
79 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
165 | | - | |
| 165 | + | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments