fix: defensively copy pending edit images

Author: doctarock

src/core/webview/PendingEditOperationStore.ts

@@ -29,6 +29,7 @@ export class PendingEditOperationStore {
 
 		this.operations.set(operationId, {
 			...editData,
+			images: editData.images ? [...editData.images] : undefined,
 			timeoutId,
 			createdAt: Date.now(),
 		})
@@ -45,7 +46,7 @@ export class PendingEditOperationStore {
 		return {
 			messageTs: operation.messageTs,
 			editedContent: operation.editedContent,
-			images: operation.images,
+			images: operation.images ? [...operation.images] : undefined,
 			messageIndex: operation.messageIndex,
 			apiConversationHistoryIndex: operation.apiConversationHistoryIndex,
 		}

src/core/webview/__tests__/PendingEditOperationStore.spec.ts

@@ -58,6 +58,17 @@ describe("PendingEditOperationStore", () => {
 		expect(operation).not.toHaveProperty("createdAt")
 	})
 
+	it("protects stored images from external mutation", () => {
+		const images = ["before.png"]
+		store.set("op", { ...editData, images })
+
+		images.push("input-mutation.png")
+		const operation = store.get("op")
+		operation?.images?.push("output-mutation.png")
+
+		expect(store.get("op")?.images).toEqual(["before.png"])
+	})
+
 	it("auto-clears after timeoutMs and logs", () => {
 		store.set("op", editData)