You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/pull_request_template.md
+24-3Lines changed: 24 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -38,14 +38,35 @@ Detail the steps to test your changes. This helps reviewers verify your work.
38
38
-[ ]**Scope**: My changes are focused on the linked issue (one major feature/fix per PR).
39
39
-[ ]**Self-Review**: I have performed a thorough self-review of my code.
40
40
-[ ]**Testing**: New and/or updated tests have been added to cover my changes (if applicable).
41
+
-[ ]**Visual Snapshot** (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I've added or updated a `*.visual.tsx` snapshot in `webview-ui/`. See `webview-ui/AGENTS.md` → "When a UI change needs a snapshot".
41
42
-[ ]**Documentation Impact**: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
42
43
-[ ]**Contribution Guidelines**: I have read and agree to the [Contributor Guidelines](/CONTRIBUTING.md).
43
44
44
-
### Screenshots / Videos
45
+
### Visual Snapshots
45
46
46
47
<!--
47
-
For UI changes, please provide before-and-after screenshots or a short video of the *actual results*.
48
-
This greatly helps in understanding the visual impact of your changes.
48
+
For UI changes to static rendered state, the primary artifact is a committed
49
+
Playwright CT snapshot (`*.visual.tsx` in `webview-ui/`) — that baseline
50
+
becomes durable regression coverage for the surface. See
51
+
`webview-ui/AGENTS.md` for what deserves a snapshot.
52
+
53
+
Before/after screenshots pasted here are welcome as a review aid but are not a
54
+
substitute for the committed baseline. If a snapshot is possible, prefer the
55
+
snapshot.
56
+
-->
57
+
58
+
### Videos (interaction / animation only)
59
+
60
+
<!--
61
+
Snapshots cannot capture motion or multi-step flows. Attach a short screen
62
+
recording here when reviewers need to see:
63
+
- A new interactive flow (dropdown, form, dialog progression)
64
+
- Animation, transition, or timing behavior
65
+
- A regression that only manifests during interaction
66
+
67
+
Videos are a review aid, not regression coverage. If the *result* of the
68
+
interaction has a distinct rendered state worth protecting, still commit a
69
+
`*.visual.tsx` snapshot of that end-state alongside the video.
0 commit comments