merge: feedback

Author: edelauna

webview-ui/src/components/chat/__tests__/Announcement.spec.tsx

@@ -41,7 +41,7 @@ vi.mock("@src/i18n/TranslationContext", () => ({
 			const translations: Record<string, string> = {
 				"chat:announcement.release.heading": "What's New:",
 				"chat:announcement.release.gpt55":
-					"GPT-5.5 via OpenAI Codex: Added GPT-5.5 support in the OpenAI Codex provider so you can use the latest model straight from Roo Code.",
+					"GPT-5.5 via OpenAI Codex: Added GPT-5.5 support in the OpenAI Codex provider so you can use the latest model straight from Zoo Code.",
 				"chat:announcement.release.claudeOpus47":
 					"Claude Opus 4.7 on Vertex AI: Added Claude Opus 4.7 to the Vertex AI provider for Anthropic's newest flagship reasoning model.",
 				"chat:announcement.release.checkpointNav":
@@ -65,7 +65,7 @@ describe("Announcement", () => {
 		expect(screen.getByText("Zoo Code 3.53.0 Released")).toBeInTheDocument()
 		expect(
 			screen.getByText(
-				"GPT-5.5 via OpenAI Codex: Added GPT-5.5 support in the OpenAI Codex provider so you can use the latest model straight from Roo Code.",
+				"GPT-5.5 via OpenAI Codex: Added GPT-5.5 support in the OpenAI Codex provider so you can use the latest model straight from Zoo Code.",
 			),
 		).toBeInTheDocument()
 		expect(

webview-ui/src/components/settings/__tests__/About.spec.tsx

@@ -41,12 +41,12 @@ vi.mock("@roo/package", () => ({
 	},
 }))
 
-const defaultProps = {
-	telemetrySetting: "enabled" as const,
-	setTelemetrySetting: vi.fn(),
-}
-
 describe("About", () => {
+	const defaultProps = {
+		telemetrySetting: "enabled" as const,
+		setTelemetrySetting: vi.fn(),
+	}
+
 	beforeEach(() => {
 		vi.clearAllMocks()
 	})

webview-ui/src/components/welcome/WelcomeViewProvider.tsx

@@ -21,11 +21,14 @@ const DEFAULT_WELCOME_API_CONFIGURATION: ProviderSettings = {
 }
 
 const getWelcomeApiConfiguration = (apiConfiguration?: ProviderSettings): ProviderSettings => {
+	// validateApiConfiguration treats a missing apiProvider as valid (no switch case matches),
+	// so we explicitly fall back here before delegating to it for incomplete-but-set configs.
 	if (!apiConfiguration?.apiProvider) {
 		return DEFAULT_WELCOME_API_CONFIGURATION
 	}
 
-	if (apiConfiguration.apiProvider === "anthropic" && !apiConfiguration.apiKey) {
+	const validationError = validateApiConfiguration(apiConfiguration)
+	if (validationError) {
 		return DEFAULT_WELCOME_API_CONFIGURATION
 	}
 

webview-ui/src/components/welcome/__tests__/WelcomeViewProvider.spec.tsx

@@ -70,6 +70,12 @@ vi.mock("react-i18next", () => ({
 	},
 }))
 
+vi.mock("i18next", () => ({
+	default: {
+		t: (key: string) => key,
+	},
+}))
+
 vi.mock("@src/i18n/TranslationContext", () => ({
 	useAppTranslation: () => ({
 		t: (key: string) => key,
@@ -226,17 +232,20 @@ describe("WelcomeViewProvider", () => {
 	})
 
 	it("saves the configured provider from setup", () => {
-		renderWelcomeViewProvider({ apiConfiguration: { apiProvider: "openrouter" } })
+		const apiConfiguration = {
+			apiProvider: "openrouter" as const,
+			openRouterApiKey: "test-key",
+			openRouterModelId: openRouterDefaultModelId,
+		}
+		renderWelcomeViewProvider({ apiConfiguration })
 
 		fireEvent.click(screen.getByTestId("button-primary"))
 		fireEvent.click(screen.getByText(/welcome:providerSignup.finish/))
 
 		expect(vscode.postMessage).toHaveBeenCalledWith({
 			type: "upsertApiConfiguration",
 			text: "default",
-			apiConfiguration: {
-				apiProvider: "openrouter",
-			},
+			apiConfiguration,
 		})
 	})