fix(ThinkingBudget): gate max-output slider behind reasoning toggle

In the binary-reasoning path the max-output-tokens slider rendered even with
reasoning off, but getModelMaxOutputTokens then ignores the value (returns the
model default), so the control was interactive yet silently ignored. Guard it
with enableReasoningEffort to match the budget path, and add tests covering both
states. Addresses PR #332 review (edelauna).

Author: proyectoauraorg

webview-ui/src/components/settings/ThinkingBudget.tsx

@@ -196,7 +196,10 @@ export const ThinkingBudget = ({ apiConfiguration, setApiConfigurationField, mod
 					}>
 					{t("settings:providers.useReasoning")}
 				</Checkbox>
-				{maxOutputTokensControl}
+				{/* Only show the max-output-tokens slider when reasoning is enabled: with it off,
+				    getModelMaxOutputTokens returns the model default regardless of the slider, so an
+				    interactive-but-ignored control would mislead. Matches the budget path's guard. */}
+				{enableReasoningEffort && maxOutputTokensControl}
 			</div>
 		)
 	}

webview-ui/src/components/settings/__tests__/ThinkingBudget.spec.tsx

@@ -111,6 +111,45 @@ describe("ThinkingBudget", () => {
 		expect(screen.queryByTestId("reasoning-effort")).not.toBeInTheDocument()
 	})
 
+	const binaryReasoningModel: ModelInfo = {
+		...mockModelInfo,
+		supportsReasoningBinary: true,
+		supportsReasoningBudget: false,
+		supportsReasoningEffort: false,
+	}
+
+	it("should hide the max-output-tokens slider in binary reasoning when reasoning is off", () => {
+		// With reasoning disabled, getModelMaxOutputTokens ignores the slider value, so an
+		// interactive control would be misleading — it must not render (PR #332 review).
+		render(
+			<ThinkingBudget
+				{...defaultProps}
+				apiConfiguration={{ enableReasoningEffort: false }}
+				modelInfo={binaryReasoningModel}
+			/>,
+		)
+
+		expect(screen.getByText("settings:providers.useReasoning")).toBeInTheDocument()
+		expect(screen.queryByTestId("slider")).not.toBeInTheDocument()
+	})
+
+	it("should show and wire the max-output-tokens slider in binary reasoning when reasoning is on", () => {
+		const setApiConfigurationField = vi.fn()
+		render(
+			<ThinkingBudget
+				{...defaultProps}
+				apiConfiguration={{ enableReasoningEffort: true }}
+				setApiConfigurationField={setApiConfigurationField}
+				modelInfo={binaryReasoningModel}
+			/>,
+		)
+
+		const slider = screen.getByTestId("slider")
+		expect(slider).toBeInTheDocument()
+		fireEvent.change(slider, { target: { value: "12288" } })
+		expect(setApiConfigurationField).toHaveBeenCalledWith("modelMaxTokens", 12288)
+	})
+
 	it("should render sliders when model supports thinking", () => {
 		render(<ThinkingBudget {...defaultProps} />)