Commit 248005c
committed
fix(Task): catch updateClineMessage rejections on partial-message paths
The four fire-and-forget updateClineMessage calls in say()/ask()
partial-message branches were void-prefixed without .catch arms. The
callee's webview post is internally guarded, but its synchronous
RooCodeEventName.Message emit can throw via a consumer-attached
listener — so the void sites can produce unhandled rejections.
Replace each `void this.updateClineMessage(...)` with an explicit
.catch arm that logs the error, matching the other rejection-handling
sites in this file. Two new tests pin the say() and ask() catch arms.
Also pin the void on getCheckpointService with a rationale comment:
its top-level try/catch returns undefined on failure, so .catch is
not needed there.1 parent d122e12 commit 248005c
2 files changed
Lines changed: 101 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1188 | 1188 | | |
1189 | 1189 | | |
1190 | 1190 | | |
1191 | | - | |
1192 | | - | |
| 1191 | + | |
| 1192 | + | |
| 1193 | + | |
| 1194 | + | |
| 1195 | + | |
| 1196 | + | |
| 1197 | + | |
1193 | 1198 | | |
1194 | 1199 | | |
1195 | 1200 | | |
| |||
1227 | 1232 | | |
1228 | 1233 | | |
1229 | 1234 | | |
1230 | | - | |
1231 | | - | |
| 1235 | + | |
| 1236 | + | |
| 1237 | + | |
| 1238 | + | |
| 1239 | + | |
1232 | 1240 | | |
1233 | 1241 | | |
1234 | 1242 | | |
| |||
1674 | 1682 | | |
1675 | 1683 | | |
1676 | 1684 | | |
1677 | | - | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
1678 | 1692 | | |
1679 | 1693 | | |
1680 | 1694 | | |
| |||
1713 | 1727 | | |
1714 | 1728 | | |
1715 | 1729 | | |
1716 | | - | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
1717 | 1735 | | |
1718 | 1736 | | |
1719 | 1737 | | |
| |||
2365 | 2383 | | |
2366 | 2384 | | |
2367 | 2385 | | |
| 2386 | + | |
| 2387 | + | |
| 2388 | + | |
| 2389 | + | |
2368 | 2390 | | |
2369 | 2391 | | |
2370 | 2392 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1976 | 1976 | | |
1977 | 1977 | | |
1978 | 1978 | | |
| 1979 | + | |
| 1980 | + | |
| 1981 | + | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
| 1994 | + | |
| 1995 | + | |
| 1996 | + | |
| 1997 | + | |
| 1998 | + | |
| 1999 | + | |
| 2000 | + | |
| 2001 | + | |
| 2002 | + | |
| 2003 | + | |
| 2004 | + | |
| 2005 | + | |
| 2006 | + | |
| 2007 | + | |
| 2008 | + | |
| 2009 | + | |
| 2010 | + | |
| 2011 | + | |
| 2012 | + | |
| 2013 | + | |
| 2014 | + | |
| 2015 | + | |
| 2016 | + | |
| 2017 | + | |
| 2018 | + | |
| 2019 | + | |
| 2020 | + | |
| 2021 | + | |
| 2022 | + | |
| 2023 | + | |
| 2024 | + | |
| 2025 | + | |
| 2026 | + | |
| 2027 | + | |
| 2028 | + | |
| 2029 | + | |
| 2030 | + | |
| 2031 | + | |
| 2032 | + | |
| 2033 | + | |
| 2034 | + | |
| 2035 | + | |
| 2036 | + | |
| 2037 | + | |
| 2038 | + | |
| 2039 | + | |
| 2040 | + | |
| 2041 | + | |
| 2042 | + | |
| 2043 | + | |
| 2044 | + | |
| 2045 | + | |
| 2046 | + | |
| 2047 | + | |
| 2048 | + | |
| 2049 | + | |
| 2050 | + | |
| 2051 | + | |
1979 | 2052 | | |
1980 | 2053 | | |
1981 | 2054 | | |
| |||
0 commit comments