fix: drop the PATH fallback per review feedback

Per #248 review (edelauna): rely only on VS Code's bundled ripgrep — the fix keeps the @vscode/ripgrep-universal/bin/<platform>-<arch>/ resolution that VS Code Insiders' staged-install builds use (the original bug) but drops the system-PATH probe. This also addresses the Copilot trust-model note at the old line 111 (a PATH-resolved rg could be user-controlled) and clears the codecov gap — the uncovered lines were the PATH helper.

Author: 0xMink

src/services/ripgrep/__tests__/index.spec.ts

@@ -1,7 +1,7 @@
 // npx vitest run src/services/ripgrep/__tests__/index.spec.ts
 
 import path from "path"
-import { vi, describe, it, expect, beforeEach, afterEach } from "vitest"
+import { vi, describe, it, expect, beforeEach } from "vitest"
 
 import { truncateLine, getBinPath } from "../index"
 import { fileExistsAtPath } from "../../../utils/fs"
@@ -63,21 +63,12 @@ describe("getBinPath", () => {
 	const appRoot = "/fake/vscode/appRoot"
 	const binName = process.platform.startsWith("win") ? "rg.exe" : "rg"
 	const platformDir = `${process.platform}-${process.arch}`
-	const originalPath = process.env.PATH
 
 	beforeEach(() => {
 		mockFileExists.mockReset()
 		mockFileExists.mockResolvedValue(false)
 	})
 
-	afterEach(() => {
-		if (originalPath === undefined) {
-			delete process.env.PATH
-		} else {
-			process.env.PATH = originalPath
-		}
-	})
-
 	it("resolves ripgrep from the classic @vscode/ripgrep layout", async () => {
 		const rg = path.join(appRoot, "node_modules/@vscode/ripgrep/bin", binName)
 		mockFileExists.mockImplementation(async (p: string) => p === rg)
@@ -92,25 +83,7 @@ describe("getBinPath", () => {
 		expect(await getBinPath(appRoot)).toBe(rg)
 	})
 
-	it("falls back to ripgrep on the system PATH when the VS Code copy is absent", async () => {
-		process.env.PATH = ["/fake/empty", "/fake/tools"].join(path.delimiter)
-		const rg = path.join("/fake/tools", binName)
-		mockFileExists.mockImplementation(async (p: string) => p === rg)
-
-		expect(await getBinPath(appRoot)).toBe(rg)
-	})
-
-	it("prefers the VS Code copy over the system PATH", async () => {
-		process.env.PATH = "/fake/tools"
-		const vscodeRg = path.join(appRoot, "node_modules/@vscode/ripgrep/bin", binName)
-		const pathRg = path.join("/fake/tools", binName)
-		mockFileExists.mockImplementation(async (p: string) => p === vscodeRg || p === pathRg)
-
-		expect(await getBinPath(appRoot)).toBe(vscodeRg)
-	})
-
-	it("returns undefined when ripgrep cannot be found anywhere", async () => {
-		process.env.PATH = "/fake/empty"
+	it("returns undefined when ripgrep cannot be found", async () => {
 		mockFileExists.mockResolvedValue(false)
 
 		expect(await getBinPath(appRoot)).toBeUndefined()

src/services/ripgrep/index.ts

@@ -85,47 +85,13 @@ export function truncateLine(line: string, maxLength: number = MAX_LINE_LENGTH):
 	return line.length > maxLength ? line.substring(0, maxLength) + " [truncated...]" : line
 }
 /**
- * Look up the ripgrep binary on the system PATH.
+ * Get the path to the ripgrep binary shipped inside the VS Code installation.
  *
- * Used as a fallback after the VS Code installation has been checked. Covers
- * VS Code forks whose install layout is not recognized by getBinPath, headless
- * / CLI hosts with no VS Code installation, and machines where the user has
- * installed ripgrep themselves.
- */
-async function findRipgrepOnPath(): Promise<string | undefined> {
-	const pathEnv = process.env.PATH
-
-	if (!pathEnv) {
-		return undefined
-	}
-
-	for (const dir of pathEnv.split(path.delimiter)) {
-		if (dir.length === 0) {
-			continue
-		}
-
-		const candidate = path.join(dir, binName)
-
-		if (await fileExistsAtPath(candidate)) {
-			return candidate
-		}
-	}
-
-	return undefined
-}
-
-/**
- * Get the path to the ripgrep binary.
- *
- * Resolution order:
- *  1. ripgrep shipped inside the VS Code installation. Both the long-standing
- *     `@vscode/ripgrep` layout and the newer `@vscode/ripgrep-universal`
- *     layout are checked — the latter is what VS Code Insiders' staged-install
- *     builds use (see microsoft/vscode#252063).
- *  2. ripgrep on the system PATH — covers VS Code forks with an unrecognized
- *     install layout, headless / CLI hosts, and a user-installed ripgrep.
+ * Both the long-standing `@vscode/ripgrep` layout and the newer
+ * `@vscode/ripgrep-universal` layout are checked — the latter is what VS Code
+ * Insiders' staged-install builds use (see microsoft/vscode#252063).
  *
- * Returns `undefined` when ripgrep cannot be located anywhere.
+ * Returns `undefined` when ripgrep cannot be located.
  */
 export async function getBinPath(vscodeAppRoot: string): Promise<string | undefined> {
 	const checkPath = async (pkgFolder: string) => {
@@ -139,8 +105,7 @@ export async function getBinPath(vscodeAppRoot: string): Promise<string | undefi
 		(await checkPath("node_modules.asar.unpacked/vscode-ripgrep/bin/")) ||
 		(await checkPath("node_modules.asar.unpacked/@vscode/ripgrep/bin/")) ||
 		(await checkPath(`node_modules/@vscode/ripgrep-universal/${ripgrepUniversalBinDir}`)) ||
-		(await checkPath(`node_modules.asar.unpacked/@vscode/ripgrep-universal/${ripgrepUniversalBinDir}`)) ||
-		(await findRipgrepOnPath())
+		(await checkPath(`node_modules.asar.unpacked/@vscode/ripgrep-universal/${ripgrepUniversalBinDir}`))
 	)
 }