fix(moonshot): address PR review feedback — add tests and fix inline import type

- Replace inline import() type with top-level OpenAI.Chat.Completions.X in moonshot.ts
- Add useSelectedModel moonshot tests (default model, router override, unknown fallback, getValidatedModelId)
- Add modelCache moonshot dispatch test for fetchModelsFromProvider switch
- Create Moonshot.spec.tsx with state machine tests (idle/loading/success/error states, race condition guard)

Author: grizmin

src/api/providers/fetchers/__tests__/modelCache.spec.ts

@@ -43,6 +43,7 @@ vi.mock("fs", () => ({
 vi.mock("../litellm")
 vi.mock("../openrouter")
 vi.mock("../requesty")
+vi.mock("../moonshot")
 
 // Mock ContextProxy with a simple static instance
 vi.mock("../../../core/config/ContextProxy", () => ({
@@ -63,10 +64,12 @@ import { getModels, getModelsFromCache } from "../modelCache"
 import { getLiteLLMModels } from "../litellm"
 import { getOpenRouterModels } from "../openrouter"
 import { getRequestyModels } from "../requesty"
+import { getMoonshotModels } from "../moonshot"
 
 const mockGetLiteLLMModels = getLiteLLMModels as Mock<typeof getLiteLLMModels>
 const mockGetOpenRouterModels = getOpenRouterModels as Mock<typeof getOpenRouterModels>
 const mockGetRequestyModels = getRequestyModels as Mock<typeof getRequestyModels>
+const mockGetMoonshotModels = getMoonshotModels as Mock<typeof getMoonshotModels>
 
 const DUMMY_REQUESTY_KEY = "requesty-key-for-testing"
 
@@ -143,6 +146,27 @@ describe("getModels with new GetModelsOptions", () => {
 		).rejects.toThrow("LiteLLM connection failed")
 	})
 
+	it("calls getMoonshotModels with correct parameters", async () => {
+		const mockModels = {
+			"kimi-k2-0905-preview": {
+				maxTokens: 16384,
+				contextWindow: 262144,
+				supportsPromptCache: true,
+				description: "Moonshot Kimi K2",
+			},
+		}
+		mockGetMoonshotModels.mockResolvedValue(mockModels)
+
+		const result = await getModels({
+			provider: "moonshot",
+			apiKey: "test-key",
+			baseUrl: "https://api.moonshot.ai/v1",
+		})
+
+		expect(mockGetMoonshotModels).toHaveBeenCalledWith("https://api.moonshot.ai/v1", "test-key")
+		expect(result).toEqual(mockModels)
+	})
+
 	it("validates exhaustive provider checking with unknown provider", async () => {
 		// This test ensures TypeScript catches unknown providers at compile time
 		// In practice, the discriminated union should prevent this at compile time

src/api/providers/moonshot.ts

@@ -1,3 +1,5 @@
+import OpenAI from "openai"
+
 import { moonshotModels, moonshotDefaultModelId, type ModelInfo } from "@roo-code/types"
 
 import type { ApiHandlerOptions } from "../../shared/api"
@@ -76,8 +78,8 @@ export class MoonshotHandler extends OpenAiHandler {
 	 */
 	protected override addMaxTokensIfNeeded(
 		requestOptions:
-			| import("openai/resources/chat/completions").ChatCompletionCreateParamsStreaming
-			| import("openai/resources/chat/completions").ChatCompletionCreateParamsNonStreaming,
+			| OpenAI.Chat.Completions.ChatCompletionCreateParamsStreaming
+			| OpenAI.Chat.Completions.ChatCompletionCreateParamsNonStreaming,
 		modelInfo: ModelInfo,
 	): void {
 		// Moonshot always requires max_tokens (not max_completion_tokens)