🐛 fix: replace setTimeout(100) with waitUntilReady() and remove dead code (#632)

Author: HappyLiang12

apps/vscode-e2e/src/suite/providers/zai.test.ts

@@ -35,7 +35,6 @@ function installZAiFetchInterceptor(
 	passthrough?: boolean,
 ): () => void {
 	const original = globalThis.fetch
-	const capturedRequests: Array<{ maxTokens?: number }> = []
 
 	globalThis.fetch = async function (input: RequestInfo | URL, init?: RequestInit): Promise<Response> {
 		const url = typeof input === "string" ? input : input instanceof URL ? input.href : (input as Request).url
@@ -48,8 +47,6 @@ function installZAiFetchInterceptor(
 					})
 				: {}
 
-			capturedRequests.push({ maxTokens: body.max_tokens })
-
 			if (capture) {
 				capture.maxTokens = body.max_tokens
 			}

src/services/mcp/__tests__/McpHub.spec.ts

@@ -2128,7 +2128,7 @@ describe("McpHub", () => {
 			const mcpHub = new McpHub(mockProvider as ClineProvider)
 
 			// Wait for initialization
-			await new Promise((resolve) => setTimeout(resolve, 100))
+			await mcpHub.waitUntilReady()
 
 			// Verify StdioClientTransport was called with wrapped command
 			expect(StdioClientTransport).toHaveBeenCalledWith(
@@ -2192,7 +2192,7 @@ describe("McpHub", () => {
 			const mcpHub = new McpHub(mockProvider as ClineProvider)
 
 			// Wait for initialization
-			await new Promise((resolve) => setTimeout(resolve, 100))
+			await mcpHub.waitUntilReady()
 
 			// Verify StdioClientTransport was called without wrapping
 			expect(StdioClientTransport).toHaveBeenCalledWith(
@@ -2256,7 +2256,7 @@ describe("McpHub", () => {
 			const mcpHub = new McpHub(mockProvider as ClineProvider)
 
 			// Wait for initialization
-			await new Promise((resolve) => setTimeout(resolve, 100))
+			await mcpHub.waitUntilReady()
 
 			// Verify StdioClientTransport was called without double-wrapping
 			expect(StdioClientTransport).toHaveBeenCalledWith(
@@ -2333,7 +2333,7 @@ describe("McpHub", () => {
 			const mcpHub = new McpHub(mockProvider as ClineProvider)
 
 			// Wait for initialization
-			await new Promise((resolve) => setTimeout(resolve, 100))
+			await mcpHub.waitUntilReady()
 
 			// Verify that the command was wrapped with cmd.exe
 			expect(StdioClientTransport).toHaveBeenCalledWith(
@@ -2402,7 +2402,7 @@ describe("McpHub", () => {
 			const mcpHub = new McpHub(mockProvider as ClineProvider)
 
 			// Wait for initialization
-			await new Promise((resolve) => setTimeout(resolve, 100))
+			await mcpHub.waitUntilReady()
 
 			// Verify StdioClientTransport was called without double-wrapping
 			expect(StdioClientTransport).toHaveBeenCalledWith(