Commit 496100f
fix(diff-view): restore scroll position and fix tab handling on save/deny (#589)
* fix(diff-view): restore scroll position and fix tab handling on save/deny
* fix(diff-view): restore preview tabs to their original editor group
* feat: keep diff target tab open on user interaction, mirror scroll position
* feat(settings): expose auto-close diff-view tab settings in UI tab
- Add autoCloseZooOpenedFiles, autoCloseZooOpenedFilesAfterUserEdited,
and autoCloseZooOpenedNewFiles to global settings schema
- Render checkboxes for all three in UISettings component
- Wire through SettingsView cachedState
- Add i18n keys under ui namespace in all 18 locales
- Add UISettings.spec.tsx tests for the new checkboxes
- Add changeset
* fix(diff-view): fix CI under vitest v4 and address review feedback
CI fixes (DiffViewProvider.spec.ts):
- check-types: cast partial task mock to satisfy Task param (TS2345)
- platform-unit-test: convert Range/Position/Selection arrow mocks to
regular functions so they are constructable under vitest v4
(v4 invokes mockImplementation as a constructor for `new`)
Review feedback:
- reset(): dispose listeners + cancelDeferredScroll before closeAllDiffViews
- add regression test: revertChanges ignores userTouchedDiffEditor (deny)
- replace scrollCallback non-null assertion with a defensive guard
- reword changeset preview-tab sentence
- restore proper diacritics/Cyrillic in de/fr/it/ru/vi auto-close settings
---------
Co-authored-by: Naved Merchant <naved.merchant@gmail.com>1 parent 4bd0645 commit 496100f
28 files changed
Lines changed: 2195 additions & 22 deletions
File tree
- .changeset
- packages/types/src
- src/integrations/editor
- __tests__
- webview-ui/src
- components/settings
- __tests__
- i18n/locales
- ca
- de
- en
- es
- fr
- hi
- id
- it
- ja
- ko
- nl
- pl
- pt-BR
- ru
- tr
- vi
- zh-CN
- zh-TW
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
183 | 186 | | |
184 | 187 | | |
185 | 188 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
282 | 282 | | |
283 | 283 | | |
284 | 284 | | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
285 | 288 | | |
286 | 289 | | |
287 | 290 | | |
| |||
Large diffs are not rendered by default.
0 commit comments