Skip to content

Commit 4e0b0e7

Browse files
committed
fix(tests): remove unused createMockStream helpers from abort signal tests (#404)
CodeRabbit nitpick: three test cases had duplicate unused helper functions (createMockStream + mockUsage) that were never called. Removed dead code and inlined the usage Promise directly in each mockReturnValue call.
1 parent ee47fbb commit 4e0b0e7

1 file changed

Lines changed: 3 additions & 36 deletions

File tree

src/api/providers/__tests__/openai-compatible-abort-signal.spec.ts

Lines changed: 3 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,9 @@ describe("OpenAICompatibleHandler abort signal", () => {
7070
yield { type: "text-delta", text: "Test response" }
7171
}
7272

73-
function createMockStream(yieldValue: any) {
74-
return {
75-
fullStream: (async function* () {
76-
yield yieldValue
77-
})(),
78-
usage: Promise.resolve({ inputTokens: 10, outputTokens: 5 }),
79-
}
80-
}
81-
82-
const mockUsage = Promise.resolve({ inputTokens: 10, outputTokens: 5 })
83-
8473
mockStreamText.mockReturnValue({
8574
fullStream: mockFullStream(),
86-
usage: mockUsage,
75+
usage: Promise.resolve({ inputTokens: 10, outputTokens: 5 }),
8776
})
8877

8978
await handler
@@ -105,20 +94,9 @@ describe("OpenAICompatibleHandler abort signal", () => {
10594
yield { type: "text-delta", text: "Test response" }
10695
}
10796

108-
function createMockStream(yieldValue: any) {
109-
return {
110-
fullStream: (async function* () {
111-
yield yieldValue
112-
})(),
113-
usage: Promise.resolve({ inputTokens: 10, outputTokens: 5 }),
114-
}
115-
}
116-
117-
const mockUsage = Promise.resolve({ inputTokens: 10, outputTokens: 5 })
118-
11997
mockStreamText.mockReturnValue({
12098
fullStream: mockFullStream(),
121-
usage: mockUsage,
99+
usage: Promise.resolve({ inputTokens: 10, outputTokens: 5 }),
122100
})
123101

124102
await handler
@@ -139,20 +117,9 @@ describe("OpenAICompatibleHandler abort signal", () => {
139117
yield { type: "text-delta", text: "Test response" }
140118
}
141119

142-
function createMockStream(yieldValue: any) {
143-
return {
144-
fullStream: (async function* () {
145-
yield yieldValue
146-
})(),
147-
usage: Promise.resolve({ inputTokens: 10, outputTokens: 5 }),
148-
}
149-
}
150-
151-
const mockUsage = Promise.resolve({ inputTokens: 10, outputTokens: 5 })
152-
153120
mockStreamText.mockReturnValue({
154121
fullStream: mockFullStream(),
155-
usage: mockUsage,
122+
usage: Promise.resolve({ inputTokens: 10, outputTokens: 5 }),
156123
})
157124

158125
await handler.createMessage(systemPrompt, messages).next()

0 commit comments

Comments
 (0)