fix(bailian): enable temperature for all models, fail-fast on handler errors, and fix custom model detection (#420)

- Enable temperature support for all models including unmatched API-fetched
  ones by changing supportsTemperature from false to true in both the handler
  fallback (src/api/providers/bailian.ts) and the fetcher minimal metadata
  (src/api/providers/fetchers/bailian.ts). Temperature remains undefined by
  default and is only sent when the user explicitly enables it.

- Fail fast in Task constructor when buildApiHandler throws, replacing the
  previous silent fallback that set this.api to undefined
  (src/core/task/Task.ts). Update the corresponding test to expect a throw
  rather than a degraded Task instance (src/core/task/__tests__/Task.spec.ts).

- Add matchesPresetLocally() in Bailian settings UI to correctly recognize
  versioned/named-space API-returned model IDs as preset models, preventing
  stale custom model overrides from leaking into preset-model usage
  (webview-ui/src/components/settings/providers/Bailian.tsx).

Author: F915

src/api/providers/bailian.ts

@@ -119,7 +119,7 @@ export class BailianHandler extends BaseOpenAiCompatibleProvider<BailianModelId>
 				contextWindow: 200_000,
 				supportsImages: false,
 				supportsPromptCache: false,
-				supportsTemperature: false,
+				supportsTemperature: true,
 			} as ModelInfo)
 
 		const info: ModelInfo = { ...baseInfo, ...price, ...(custom || {}) }

src/api/providers/fetchers/bailian.ts

@@ -186,7 +186,7 @@ export async function getBailianModels(baseUrl?: string, apiKey?: string): Promi
 					contextWindow: 200_000,
 					supportsImages: false,
 					supportsPromptCache: false,
-					supportsTemperature: false,
+					supportsTemperature: true,
 				}
 			}
 		}

src/core/task/Task.ts

@@ -494,7 +494,7 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 			TelemetryService.instance.captureException(error instanceof Error ? error : new Error(String(error)), {
 				extra: { provider: apiConfiguration.apiProvider, action: "Task.constructor" },
 			})
-			this.api = undefined as any
+			throw error
 		}
 		this.autoApprovalHandler = new AutoApprovalHandler()
 

src/core/task/__tests__/Task.spec.ts

@@ -396,7 +396,7 @@ describe("Cline", () => {
 			}).toThrow("Either historyItem or task/images must be provided")
 		})
 
-		it("constructor catches buildApiHandler failure without crashing", () => {
+		it("constructor rethrows buildApiHandler failure", () => {
 			// Spy on buildApiHandler to throw simulating an invalid config
 			const buildApiHandlerSpy = vi.spyOn(apiModule, "buildApiHandler").mockImplementationOnce(() => {
 				throw new Error("Invalid Bailian config: missing workspaceId for frankfurt region")
@@ -405,22 +405,24 @@ describe("Cline", () => {
 			// Spy on TelemetryService captureException
 			const captureExceptionSpy = vi.spyOn(TelemetryService.instance, "captureException")
 
-			const task = new Task({
-				provider: mockProvider,
-				apiConfiguration: {
-					apiProvider: "bailian",
-					bailianRegion: "frankfurt",
-					// Missing bailianWorkspaceId — should trigger buildApiHandler to throw
-				} as ProviderSettings,
-				task: "test task",
-				startTask: false,
-			})
+			// Constructor should throw — no Task instance is created
+			// with an undefined this.api (fail-fast, consistent with
+			// updateApiConfiguration).
+			expect(
+				() =>
+					new Task({
+						provider: mockProvider,
+						apiConfiguration: {
+							apiProvider: "bailian",
+							bailianRegion: "frankfurt",
+							// Missing bailianWorkspaceId — should trigger buildApiHandler to throw
+						} as ProviderSettings,
+						task: "test task",
+						startTask: false,
+					}),
+			).toThrow("Invalid Bailian config")
 
-			// Task instance should be created successfully (no crash)
-			expect(task).toBeDefined()
-			// api should be undefined since handler construction failed
-			expect((task as any).api).toBeUndefined()
-			// Telemetry should have captured the exception
+			// Telemetry should have captured the exception (logged before rethrow)
 			expect(captureExceptionSpy).toHaveBeenCalledTimes(1)
 			const capturedError = captureExceptionSpy.mock.calls[0][0]
 			expect(capturedError.message).toContain("Invalid Bailian config")

webview-ui/src/components/settings/providers/Bailian.tsx

@@ -22,6 +22,27 @@ import { handleModelChangeSideEffects } from "../utils/providerModelConfig"
 import { ModelPicker } from "../ModelPicker"
 import { cn } from "@/lib/utils"
 
+/**
+ * Mirrors the handler-side findMatchingPreset() logic from
+ * src/api/providers/fetchers/bailian.ts for use in the webview
+ * context where we cannot import from the extension host.
+ *
+ * Returns true when the given model ID is an exact or substring
+ * match (case-insensitive) of a static preset key, meaning the
+ * handler will resolve it to a known preset rather than treating
+ * it as unknown/custom.
+ */
+function matchesPresetLocally(modelId: string): boolean {
+	const lower = modelId.trim().toLowerCase()
+	if (!lower) return false
+	const presetKeys = Object.keys(bailianModels)
+	// Exact match (case-insensitive)
+	if (presetKeys.some((k) => k.toLowerCase() === lower)) return true
+	// Substring match — e.g. "qwen3.7-max" is a substring of
+	// the API-returned "qwen3.7-max-2026-05-17"
+	return presetKeys.some((k) => lower.includes(k.toLowerCase()))
+}
+
 type BailianProps = {
 	apiConfiguration: ProviderSettings
 	setApiConfigurationField: <K extends keyof ProviderSettings>(
@@ -97,7 +118,7 @@ export const Bailian = ({
 	}, [routerModels?.bailian])
 
 	const modelId = (apiConfiguration.apiModelId ?? "").trim()
-	const isCustomModel = !!(modelId && !knownModelIds.has(modelId))
+	const isCustomModel = !!(modelId && !knownModelIds.has(modelId) && !matchesPresetLocally(modelId))
 
 	// Stable sort callback so ModelPicker's useMemo dependency doesn't
 	// invalidate on every render.
@@ -197,7 +218,7 @@ export const Bailian = ({
 					// Clear custom model overrides when switching to a preset
 					// model so stale bailianCustomModelInfo doesn't leak into
 					// the UI display or API requests.
-					if (knownModelIds.has(newModelId)) {
+					if (knownModelIds.has(newModelId) || matchesPresetLocally(newModelId)) {
 						setApiConfigurationField("bailianCustomModelInfo", null)
 					}
 				}}