fix(readFileTool): align legacy path failure flag with native path; drop temp warn

Author: proyectoauraorg

packages/types/src/tool-params.ts

@@ -89,7 +89,9 @@ export type ReadFileToolParams = ReadFileParams | LegacyReadFileParams
  * Type guard to check if params are in legacy format.
  */
 export function isLegacyReadFileParams(params: ReadFileToolParams): params is LegacyReadFileParams {
-	// Detect explicit flag (new code path) or bare `files` array (real legacy chat data)
+	// `NativeToolCallParser` always tags freshly parsed legacy calls with `_legacyFormat: true`.
+	// The bare-`files` fallback only matters for chat history persisted before that flag was
+	// introduced (commit cc86049f1) and re-hydrated on a later run.
 	const hasLegacyFlag = "_legacyFormat" in params && params._legacyFormat === true
 	const hasFilesArray = "files" in params && Array.isArray((params as unknown as Record<string, unknown>).files)
 	return hasLegacyFlag || hasFilesArray

src/core/tools/ReadFileTool.ts

@@ -668,9 +668,6 @@ export class ReadFileTool extends BaseTool<"read_file"> {
 		const { pushToolResult } = callbacks
 		const modelInfo = task.api.getModel().info
 
-		// Temporary indicator for testing legacy format detection
-		console.warn("[read_file] Legacy format detected - using backward compatibility path")
-
 		if (!fileEntries || fileEntries.length === 0) {
 			task.consecutiveMistakeCount++
 			task.recordToolError("read_file")
@@ -694,6 +691,8 @@ export class ReadFileTool extends BaseTool<"read_file"> {
 				await task.say("rooignore_error", relPath)
 				const errorMsg = formatResponse.rooIgnoreError(relPath)
 				results.push(`File: ${relPath}\nError: ${errorMsg}`)
+				// Mirror the native path: a blocked file marks the tool turn as failed.
+				task.didToolFailInCurrentTurn = true
 				continue
 			}
 

src/core/tools/__tests__/readFileTool.spec.ts

@@ -748,14 +748,10 @@ describe("ReadFileTool", () => {
 			mockTask.ask.mockResolvedValue({ response: "yesButtonClicked", text: undefined, images: undefined })
 			mockedFsReadFile.mockResolvedValue(Buffer.from("legacy content"))
 
-			const consoleWarnSpy = vi.spyOn(console, "warn").mockImplementation(() => {})
-
 			await readFileTool.execute({ files: [{ path: "legacy.ts" }] } as any, mockTask as any, callbacks)
 
-			expect(consoleWarnSpy).toHaveBeenCalledWith(expect.stringContaining("Legacy format detected"))
+			// The legacy path emits "File: <path>" entries — proof the backward-compat branch ran.
 			expect(callbacks.pushToolResult).toHaveBeenCalledWith(expect.stringContaining("File: legacy.ts"))
-
-			consoleWarnSpy.mockRestore()
 		})
 
 		it("should return error when legacy files array is empty", async () => {
@@ -816,6 +812,8 @@ describe("ReadFileTool", () => {
 
 			expect(mockTask.say).toHaveBeenCalledWith("rooignore_error", "secret.env")
 			expect(callbacks.pushToolResult).toHaveBeenCalledWith(expect.stringContaining("blocked by the .rooignore"))
+			// Consistent with the native path: a blocked file fails the tool turn.
+			expect(mockTask.didToolFailInCurrentTurn).toBe(true)
 		})
 
 		it("should deny legacy file read when user clicks no", async () => {