fix(telemetry): respect consent and stabilize CI tests

Author: edelauna

apps/vscode-e2e/src/fixtures/subtasks.ts

@@ -32,6 +32,7 @@ export const SUBTASK_API_HANG_PARENT_PROMPT = `${SUBTASK_API_HANG_PARENT_MARKER}
 export const SUBTASK_API_HANG_RESUME_MESSAGE = "Continue after provider hang."
 export const SUBTASK_API_HANG_CHILD_RESULT = "Hung child completed"
 export const SUBTASK_API_HANG_PARENT_RESULT = "API hang parent resumed"
+export const SUBTASK_API_HANG_RESPONSE_LATENCY_MS = 15_000
 
 // Abandon-subtask scenario (#559) — separate markers to avoid sequenceIndex collisions with the
 // interrupted-child-resumes tests above, which exhaust the sequence count for INTERRUPT markers.
@@ -262,7 +263,7 @@ export function addSubtaskFixtures(mock: InstanceType<typeof LLMock>) {
 			sequenceIndex: 0,
 		},
 		// Keep the first child response pending long enough for the e2e test to cancel an in-flight API request.
-		latency: 15_000,
+		latency: SUBTASK_API_HANG_RESPONSE_LATENCY_MS,
 		response: {
 			toolCalls: [
 				{

apps/vscode-e2e/src/suite/subtasks.test.ts

@@ -17,6 +17,7 @@ import {
 	SUBTASK_API_HANG_PARENT_PROMPT,
 	SUBTASK_API_HANG_PARENT_RESULT,
 	SUBTASK_API_HANG_RESUME_MESSAGE,
+	SUBTASK_API_HANG_RESPONSE_LATENCY_MS,
 	SUBTASK_CHILD_FOLLOWUP_ANSWER,
 	SUBTASK_FAST_CHILD_RESULT,
 	SUBTASK_FAST_PARENT_PROMPT,
@@ -72,6 +73,12 @@ const waitForAimockRequestContaining = async (expectedText: string, excludeText?
 suite("Roo Code Subtasks", function () {
 	setDefaultSuiteTimeout(this)
 
+	// Task cancellation aborts the client request asynchronously. Let the extension host
+	// finish disposing it before the next test reuses the mock server.
+	teardown(async () => {
+		await sleep(1_500)
+	})
+
 	test("child completing on its first response returns to parent", async () => {
 		const api = globalThis.api
 		const says: Record<string, ClineMessage[]> = {}
@@ -580,6 +587,9 @@ suite("Roo Code Subtasks", function () {
 				await api.clearCurrentTask()
 			}
 			await waitFor(() => api.getCurrentTaskStack().length === 0).catch(() => {})
+			// aimock does not cancel delayed server-side streams when the client aborts.
+			// Drain this fixture before the next test can open another streamed request.
+			await sleep(SUBTASK_API_HANG_RESPONSE_LATENCY_MS)
 		}
 	})
 

packages/telemetry/src/TelemetryService.ts

@@ -150,6 +150,10 @@ export class TelemetryService {
 			return
 		}
 
+		if (!this.isTelemetryEnabled()) {
+			return
+		}
+
 		if (this.shouldDropForCircuitBreaker(eventName)) {
 			return
 		}

src/__tests__/history-resume-delegation.spec.ts

@@ -1255,6 +1255,7 @@ describe("History resume delegation - parent metadata transitions", () => {
 				userMessageContent: [],
 				consecutiveMistakeCount: 0,
 				emitFinalTokenUsageUpdate: vi.fn(),
+				flushTelemetryInstallment: vi.fn(),
 			} as unknown as import("../core/task/Task").Task
 
 			const block = {

src/api/providers/fetchers/__tests__/modelCache.spec.ts

@@ -5,6 +5,7 @@ vi.mock("@roo-code/telemetry", () => ({
 	TelemetryService: {
 		instance: {
 			captureEvent: vi.fn(),
+			isTelemetryEnabled: vi.fn().mockReturnValue(true),
 		},
 	},
 }))

src/api/providers/fetchers/modelCache.ts

@@ -59,6 +59,10 @@ function captureModelCacheEmptyResponseOnce(
 		return
 	}
 
+	if (!TelemetryService.instance.isTelemetryEnabled()) {
+		return
+	}
+
 	reportedEmptyModelResponse.add(cacheKey)
 	TelemetryService.instance.captureEvent(TelemetryEventName.MODEL_CACHE_EMPTY_RESPONSE, { provider, ...properties })
 }

src/extension.ts

@@ -174,17 +174,22 @@ export async function activate(context: vscode.ExtensionContext) {
 	}
 
 	const contextProxy = await ContextProxy.getInstance(context)
+	const updateTelemetryState = () => {
+		const telemetrySetting = contextProxy.getGlobalState("telemetrySetting") ?? "unset"
+		TelemetryService.instance.updateTelemetryState(
+			isTelemetryOptedIn(telemetrySetting) && vscode.env.isTelemetryEnabled,
+		)
+	}
+
+	updateTelemetryState()
 
 	// React live to VS Code's global telemetry toggle (recommended over only reading
 	// telemetry.telemetryLevel, which PostHogTelemetryClient still checks as a secondary gate).
 	// vscode.env.isTelemetryEnabled is ANDed in directly because the deprecated
 	// telemetry.telemetryLevel setting the client checks doesn't reflect this live event.
 	context.subscriptions.push(
 		vscode.env.onDidChangeTelemetryEnabled(() => {
-			const telemetrySetting = contextProxy.getGlobalState("telemetrySetting") ?? "unset"
-			TelemetryService.instance.updateTelemetryState(
-				isTelemetryOptedIn(telemetrySetting) && vscode.env.isTelemetryEnabled,
-			)
+			updateTelemetryState()
 
 			// Push the new vscode.env.isTelemetryEnabled value to the webview too, so its
 			// own PostHog client (gated separately in TelemetryClient.ts) can't keep