refactor: coderabbit review for edge cases

Author: edelauna

.github/workflows/code-qa.yml

@@ -62,7 +62,7 @@ jobs:
               uses: actions/cache@v4
               with:
                   path: .turbo/cache
-                  key: ${{ runner.os }}-turbo-${{ hashFiles('**/pnpm-lock.yaml') }}-${{ github.sha }}
+                  key: ${{ runner.os }}-turbo-${{ hashFiles('**/pnpm-lock.yaml') }}
                   restore-keys: |
                       ${{ runner.os }}-turbo-${{ hashFiles('**/pnpm-lock.yaml') }}-
                       ${{ runner.os }}-turbo-

.github/workflows/e2e.yml

@@ -10,6 +10,10 @@ on:
             - "webview-ui/**"
             - "apps/vscode-e2e/**"
             - "packages/core/**"
+            - "package.json"
+            - "pnpm-lock.yaml"
+            - "turbo.json"
+            - ".github/actions/setup-node-pnpm/**"
 
 jobs:
     e2e-mock:

apps/vscode-e2e/src/runTest.ts

@@ -18,47 +18,6 @@ async function main() {
 
 	let mock: InstanceType<typeof LLMock> | undefined
 
-	if (useMock) {
-		const fixturesDir = path.resolve(__dirname, "../fixtures")
-
-		mock = new LLMock({
-			port: 0, // random free port
-			...(isRecord && {
-				record: {
-					// OpenRouter is OpenAI-compatible; aimock proxies using the openai provider key.
-					// Use /api (not /api/v1) — aimock appends the request path (/v1/chat/completions)
-					// so including /v1 here would produce a doubled /v1/v1 upstream URL.
-					providers: { openai: "https://openrouter.ai/api" },
-					fixturePath: fixturesDir,
-				},
-			}),
-		})
-
-		mock.loadFixtureDir(fixturesDir)
-
-		if (!isRecord) {
-			// The modes test (switch_mode → ask) triggers a second API call whose last
-			// user message starts with <environment_details> directly — no <user_message>
-			// wrapper. JSON fixtures use substring matching so a bare "<environment_details>"
-			// match would collide with all other requests. A regex anchored to the start
-			// uniquely identifies this post-switch turn.
-			mock.addFixture({
-				match: { userMessage: /^<environment_details>/ },
-				response: {
-					toolCalls: [
-						{
-							name: "attempt_completion",
-							arguments: JSON.stringify({ result: "Switched to ❓ Ask mode as requested." }),
-							id: "call_modes_post_switch_001",
-						},
-					],
-				},
-			})
-		}
-
-		await mock.start()
-	}
-
 	// The folder containing the Extension Manifest package.json
 	// Passed to `--extensionDevelopmentPath`
 	const extensionDevelopmentPath = path.resolve(__dirname, "../../../src")
@@ -70,6 +29,47 @@ async function main() {
 	let testWorkspace: string | undefined
 
 	try {
+		if (useMock) {
+			const fixturesDir = path.resolve(__dirname, "../fixtures")
+
+			mock = new LLMock({
+				port: 0, // random free port
+				...(isRecord && {
+					record: {
+						// OpenRouter is OpenAI-compatible; aimock proxies using the openai provider key.
+						// Use /api (not /api/v1) — aimock appends the request path (/v1/chat/completions)
+						// so including /v1 here would produce a doubled /v1/v1 upstream URL.
+						providers: { openai: "https://openrouter.ai/api" },
+						fixturePath: fixturesDir,
+					},
+				}),
+			})
+
+			mock.loadFixtureDir(fixturesDir)
+
+			if (!isRecord) {
+				// The modes test (switch_mode → ask) triggers a second API call whose last
+				// user message starts with <environment_details> directly — no <user_message>
+				// wrapper. JSON fixtures use substring matching so a bare "<environment_details>"
+				// match would collide with all other requests. A regex anchored to the start
+				// uniquely identifies this post-switch turn.
+				mock.addFixture({
+					match: { userMessage: /^<environment_details>/ },
+					response: {
+						toolCalls: [
+							{
+								name: "attempt_completion",
+								arguments: JSON.stringify({ result: "Switched to ❓ Ask mode as requested." }),
+								id: "call_modes_post_switch_001",
+							},
+						],
+					},
+				})
+			}
+
+			await mock.start()
+		}
+
 		// Create a temporary workspace folder for tests
 		testWorkspace = await fs.mkdtemp(path.join(os.tmpdir(), "roo-test-workspace-"))
 		// Get test filter from command line arguments or environment variable

codecov.yml

@@ -9,7 +9,7 @@ coverage:
     patch:
       default:
         target: 80%       # new lines must be 80% covered
-        threshold: 5%
+        threshold: 0%
 
 comment:
   layout: "diff, flags"