fix(terminal): close idle terminals when profile changes

Author: edelauna

src/core/webview/webviewMessageHandler.ts

@@ -50,6 +50,7 @@ import { checkExistKey } from "../../shared/checkExistApiConfig"
 import { getRouterRemovalMessage, getRouterUnavailableSignInMessage } from "../config/routerRemoval"
 import { experimentDefault } from "../../shared/experiments"
 import { Terminal } from "../../integrations/terminal/Terminal"
+import { TerminalRegistry } from "../../integrations/terminal/TerminalRegistry"
 import { openFile } from "../../integrations/misc/open-file"
 import { openImage, saveImage } from "../../integrations/misc/image-handler"
 import { selectImages } from "../../integrations/misc/process-images"
@@ -728,6 +729,10 @@ export const webviewMessageHandler = async (
 						}
 					} else if (key === "terminalProfile") {
 						Terminal.setTerminalProfile(value as string | undefined)
+						// Discard idle terminals so the next command gets a fresh
+						// terminal using the new profile's shell instead of reusing
+						// a stale one from the previous profile.
+						TerminalRegistry.closeIdleTerminals()
 					} else if (key === "execaShellPath") {
 						Terminal.setExecaShellPath(value as string | undefined)
 					} else if (key === "mcpEnabled") {

src/integrations/terminal/TerminalRegistry.ts

@@ -277,6 +277,22 @@ export class TerminalRegistry {
 		this.disposables = []
 	}
 
+	/**
+	 * Disposes all idle (non-busy) VS Code terminals so they are not reused
+	 * after a shell profile change. Busy terminals are left untouched.
+	 */
+	public static closeIdleTerminals(): void {
+		this.terminals = this.terminals.filter((t) => {
+			if (t.busy || !(t instanceof Terminal)) {
+				return true
+			}
+
+			t.terminal.dispose()
+			ShellIntegrationManager.zshCleanupTmpDir(t.id)
+			return false
+		})
+	}
+
 	/**
 	 * Releases all terminals associated with a task.
 	 *