test(webview): remove brittle identifier mutation tests

Author: WebMad

webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts

@@ -22,7 +22,6 @@ import {
 	vscodeLlmDefaultModelId,
 	moonshotDefaultModelId,
 	moonshotModels,
-	providerIdentifiers,
 } from "@roo-code/types"
 
 import { useSelectedModel } from "../useSelectedModel"
@@ -832,28 +831,6 @@ describe("useSelectedModel", () => {
 			expect(result.current.info).toEqual(openAiModelInfoSaneDefaults)
 		})
 
-		it("uses the canonical OpenAI identifier to select configured model metadata", () => {
-			const identifiers = providerIdentifiers as Record<string, string>
-			const originalIdentifier = identifiers.openai
-
-			try {
-				identifiers.openai = "canonical-openai"
-
-				const apiConfiguration = {
-					apiProvider: identifiers.openai,
-					openAiModelId: "gpt-4o",
-				} as ProviderSettings
-
-				const wrapper = createWrapper()
-				const { result } = renderHook(() => useSelectedModel(apiConfiguration), { wrapper })
-
-				expect(result.current.id).toBe("gpt-4o")
-				expect(result.current.info).toEqual(openAiModelInfoSaneDefaults)
-			} finally {
-				identifiers.openai = originalIdentifier
-			}
-		})
-
 		it("should return custom model info when provided", () => {
 			const customModelInfo: ModelInfo = {
 				maxTokens: 16384,

webview-ui/src/utils/__tests__/validate.spec.ts

@@ -1,9 +1,4 @@
-import {
-	providerIdentifiers,
-	type ProviderSettings,
-	type OrganizationAllowList,
-	type RouterModels,
-} from "@roo-code/types"
+import { type ProviderSettings, type OrganizationAllowList, type RouterModels } from "@roo-code/types"
 
 // Mock i18next to return translation keys with interpolated values
 vi.mock("i18next", () => ({
@@ -141,24 +136,6 @@ describe("Model Validation Functions", () => {
 	})
 
 	describe("validateApiConfigurationExcludingModelErrors", () => {
-		it("uses the canonical OpenRouter identifier for credential validation", () => {
-			const identifiers = providerIdentifiers as Record<string, string>
-			const originalIdentifier = identifiers.openrouter
-
-			try {
-				identifiers.openrouter = "canonical-openrouter"
-
-				const config = {
-					apiProvider: identifiers.openrouter,
-					openRouterModelId: "valid-model",
-				} as ProviderSettings
-
-				expect(validateApiConfigurationExcludingModelErrors(config)).toBe("settings:validation.apiKey")
-			} finally {
-				identifiers.openrouter = originalIdentifier
-			}
-		})
-
 		it("returns undefined when configuration is valid", () => {
 			const config: ProviderSettings = {
 				apiProvider: "openrouter",