Skip to content

Commit 879fe07

Browse files
kazenshinavedmerchant
authored andcommitted
Remove unsupported tar argument --no-absolute-filenames (#492)
* Remove unsupported tar argument --no-absolute-filenames * fix failing test --------- Co-authored-by: Naved <naved.merchant@gmail.com>
1 parent 4c60198 commit 879fe07

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

src/services/code-index/semble/__tests__/semble-downloader.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ describe("semble-downloader", () => {
235235
"-C",
236236
path.join("/storage", "semble.new"),
237237
"--no-same-owner",
238-
"--no-absolute-filenames",
239238
"--no-overwrite-dir",
240239
],
241240
expect.any(Object),

src/services/code-index/semble/semble-downloader.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,10 @@ export async function getSembleBinaryPath(storageDir: string): Promise<string |
258258
function extractTarGz(archivePath: string, destDir: string): Promise<void> {
259259
return new Promise((resolve, reject) => {
260260
const args = ["-xzf", archivePath, "-C", destDir, "--no-same-owner"]
261-
// GNU tar: --no-absolute-filenames blocks leading-slash entries,
262-
// --no-overwrite-dir adds defense-in-depth against ../relative traversal.
261+
// GNU tar: --no-overwrite-dir adds defense-in-depth against ../relative traversal.
263262
// macOS bsdtar strips absolute paths by default.
264263
if (process.platform === "linux") {
265-
args.push("--no-absolute-filenames", "--no-overwrite-dir")
264+
args.push("--no-overwrite-dir")
266265
}
267266
const child = spawn("tar", args, {
268267
shell: false,

0 commit comments

Comments
 (0)