Skip to content

Commit 9740644

Browse files
committed
fix(friendli): forward timeoutMs in completePrompt requestOptions
CodeRabbit caught that CompletePromptOptions.timeoutMs was dropped on the floor — only abortSignal was forwarded. Now both are passed to the SDK.
1 parent b8f6c8c commit 9740644

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/api/providers/friendli.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,10 @@ export class FriendliHandler extends BaseOpenAiCompatibleProvider<FriendliModelI
196196
}
197197

198198
try {
199-
const requestOptions: OpenAI.RequestOptions | undefined = options?.abortSignal
200-
? { signal: options.abortSignal }
201-
: undefined
199+
const requestOptions: OpenAI.RequestOptions | undefined =
200+
options && (options.abortSignal !== undefined || options.timeoutMs !== undefined)
201+
? { signal: options.abortSignal, timeout: options.timeoutMs }
202+
: undefined
202203
const response = (await this.client.chat.completions.create(
203204
params as OpenAI.Chat.Completions.ChatCompletionCreateParams,
204205
requestOptions,

0 commit comments

Comments
 (0)