Remove customizable path, only use downloaded semble

navedmerchant · navedmerchant · commit 9a7666c96ab2 · 2026-05-30T12:12:25.000-07:00
diff --git a/packages/types/src/codebase-index.ts b/packages/types/src/codebase-index.ts
@@ -51,8 +51,6 @@ export const codebaseIndexConfigSchema = z.object({
 	codebaseIndexBedrockProfile: z.string().optional(),
 	// OpenRouter specific fields
 	codebaseIndexOpenRouterSpecificProvider: z.string().optional(),
-	// Semble specific fields
-	codebaseIndexSemblePath: z.string().optional(),
 })
 
 export type CodebaseIndexConfig = z.infer<typeof codebaseIndexConfigSchema>
diff --git a/packages/types/src/vscode-extension-host.ts b/packages/types/src/vscode-extension-host.ts
@@ -677,7 +677,6 @@ export interface WebviewMessage {
 		codebaseIndexSearchMaxResults?: number
 		codebaseIndexSearchMinScore?: number
 		codebaseIndexOpenRouterSpecificProvider?: string // OpenRouter provider routing
-		codebaseIndexSemblePath?: string // Path to the semble executable
 
 		// Secret settings
 		codeIndexOpenAiKey?: string
diff --git a/src/core/webview/ClineProvider.ts b/src/core/webview/ClineProvider.ts
@@ -2253,7 +2253,6 @@ export class ClineProvider
 				codebaseIndexBedrockRegion: codebaseIndexConfig?.codebaseIndexBedrockRegion,
 				codebaseIndexBedrockProfile: codebaseIndexConfig?.codebaseIndexBedrockProfile,
 				codebaseIndexOpenRouterSpecificProvider: codebaseIndexConfig?.codebaseIndexOpenRouterSpecificProvider,
-				codebaseIndexSemblePath: codebaseIndexConfig?.codebaseIndexSemblePath,
 			},
 			// Phase 1 cloud removal: do not let Cloud-auth MDM enforcement force login-only UI flows.
 			mdmCompliant: undefined,
@@ -2458,7 +2457,6 @@ export class ClineProvider
 				codebaseIndexBedrockProfile: stateValues.codebaseIndexConfig?.codebaseIndexBedrockProfile,
 				codebaseIndexOpenRouterSpecificProvider:
 					stateValues.codebaseIndexConfig?.codebaseIndexOpenRouterSpecificProvider,
-				codebaseIndexSemblePath: stateValues.codebaseIndexConfig?.codebaseIndexSemblePath,
 			},
 			profileThresholds: stateValues.profileThresholds ?? {},
 			lockApiConfigAcrossModes: this.context.workspaceState.get("lockApiConfigAcrossModes", false),
diff --git a/src/core/webview/webviewMessageHandler.ts b/src/core/webview/webviewMessageHandler.ts
@@ -2500,7 +2500,6 @@ export const webviewMessageHandler = async (
 					codebaseIndexSearchMaxResults: settings.codebaseIndexSearchMaxResults,
 					codebaseIndexSearchMinScore: settings.codebaseIndexSearchMinScore,
 					codebaseIndexOpenRouterSpecificProvider: settings.codebaseIndexOpenRouterSpecificProvider,
-					codebaseIndexSemblePath: settings.codebaseIndexSemblePath,
 				}
 
 				// Save global state first
diff --git a/src/services/code-index/config-manager.ts b/src/services/code-index/config-manager.ts
@@ -22,7 +22,6 @@ export class CodeIndexConfigManager {
 	private vercelAiGatewayOptions?: { apiKey: string }
 	private bedrockOptions?: { region: string; profile?: string }
 	private openRouterOptions?: { apiKey: string; specificProvider?: string }
-	private semblePath?: string
 	private qdrantUrl?: string = "http://localhost:6333"
 	private qdrantApiKey?: string
 	private searchMinScore?: number
@@ -151,9 +150,6 @@ export class CodeIndexConfigManager {
 		this.bedrockOptions = bedrockRegion
 			? { region: bedrockRegion, profile: bedrockProfile || undefined }
 			: undefined
-
-		// Semble path (optional — defaults to "semble" in the SembleProvider)
-		this.semblePath = codebaseIndexConfig.codebaseIndexSemblePath || undefined
 	}
 
 	/**
@@ -200,7 +196,6 @@ export class CodeIndexConfigManager {
 			openRouterSpecificProvider: this.openRouterOptions?.specificProvider ?? "",
 			qdrantUrl: this.qdrantUrl ?? "",
 			qdrantApiKey: this.qdrantApiKey ?? "",
-			semblePath: this.semblePath ?? "",
 		}
 
 		// Refresh secrets from VSCode storage to ensure we have the latest values
@@ -417,13 +412,6 @@ export class CodeIndexConfigManager {
 			return true
 		}
 
-		// Semble path change requires restart to use the new executable
-		const prevSemblePath = prev?.semblePath ?? ""
-		const currentSemblePath = this.semblePath ?? ""
-		if (prevSemblePath !== currentSemblePath) {
-			return true
-		}
-
 		// Vector dimension changes (still important for compatibility)
 		if (this._hasVectorDimensionChanged(prevProvider, prev?.modelId)) {
 			return true
@@ -560,12 +548,4 @@ export class CodeIndexConfigManager {
 	public get currentSearchMaxResults(): number {
 		return this.searchMaxResults ?? DEFAULT_MAX_SEARCH_RESULTS
 	}
-
-	/**
-	 * Gets the configured path to the semble executable.
-	 * Returns undefined if not explicitly configured (provider will use default "semble").
-	 */
-	public get currentSemblePath(): string | undefined {
-		return this.semblePath
-	}
 }
diff --git a/src/services/code-index/interfaces/config.ts b/src/services/code-index/interfaces/config.ts
@@ -45,5 +45,4 @@ export type PreviousConfigSnapshot = {
 	openRouterSpecificProvider?: string
 	qdrantUrl?: string
 	qdrantApiKey?: string
-	semblePath?: string
 }
diff --git a/src/services/code-index/manager.ts b/src/services/code-index/manager.ts
@@ -404,12 +404,7 @@ export class CodeIndexManager {
 
 		// Branch: if provider is "semble", create SembleProvider instead of external services
 		if (this._configManager!.currentEmbedderProvider === "semble") {
-			this._sembleProvider = new SembleProvider(
-				this.workspacePath,
-				this.context,
-				this._stateManager,
-				this._configManager!.currentSemblePath,
-			)
+			this._sembleProvider = new SembleProvider(this.workspacePath, this.context, this._stateManager)
 			await this._sembleProvider.initialize()
 			return
 		}
diff --git a/src/services/code-index/semble/__tests__/provider.spec.ts b/src/services/code-index/semble/__tests__/provider.spec.ts
@@ -57,7 +57,7 @@ describe("SembleProvider", () => {
 			globalStorageUri: { fsPath: "/mock/storage" },
 		}
 
-		provider = new SembleProvider("/workspace", mockContext, mockStateManager, "semble")
+		provider = new SembleProvider("/workspace", mockContext, mockStateManager)
 		mockCli = sharedMockCli
 	})
 
@@ -68,13 +68,8 @@ describe("SembleProvider", () => {
 			expect(p.state).toBe("Standby")
 		})
 
-		it("should create provider with custom semble path", () => {
-			const p = new SembleProvider("/workspace", mockContext, mockStateManager, "/usr/local/bin/semble")
-			expect(p).toBeDefined()
-		})
-
 		it("should create provider with custom topK and content", () => {
-			const p = new SembleProvider("/workspace", mockContext, mockStateManager, "semble", {
+			const p = new SembleProvider("/workspace", mockContext, mockStateManager, {
 				topK: 5,
 				content: "all",
 			})
@@ -143,16 +138,6 @@ describe("SembleProvider", () => {
 
 			expect(mockCli.checkInstalled).toHaveBeenCalledTimes(1)
 		})
-
-		it("should skip download when custom semble path is configured", async () => {
-			const customProvider = new SembleProvider("/workspace", mockContext, mockStateManager, "/custom/semble")
-			mockCli.checkInstalled.mockResolvedValue({ installed: true })
-
-			await customProvider.initialize()
-
-			expect(downloadSemble).not.toHaveBeenCalled()
-			expect(customProvider.state).toBe("Indexed")
-		})
 	})
 
 	describe("startIndexing", () => {
diff --git a/src/services/code-index/semble/__tests__/semble-cli.spec.ts b/src/services/code-index/semble/__tests__/semble-cli.spec.ts
@@ -51,12 +51,7 @@ describe("SembleCLI", () => {
 	})
 
 	describe("constructor", () => {
-		it("should use default semble path", () => {
-			const defaultCli = new SembleCLI()
-			expect(defaultCli).toBeDefined()
-		})
-
-		it("should accept a custom path to the semble executable", () => {
+		it("should accept a path to the semble executable", () => {
 			const customCli = new SembleCLI("/usr/local/bin/semble")
 			expect(customCli).toBeDefined()
 		})
diff --git a/src/services/code-index/semble/provider.ts b/src/services/code-index/semble/provider.ts
@@ -21,7 +21,7 @@ import { TelemetryEventName } from "@roo-code/types"
  * to this provider instead of the ServiceFactory → orchestrator pipeline.
  */
 export class SembleProvider implements ISembleProvider {
-	private cli: SembleCLI
+	private cli!: SembleCLI
 	private readonly workspacePath: string
 	private readonly config: SembleConfig
 	private readonly stateManager: CodeIndexStateManager
@@ -34,28 +34,24 @@ export class SembleProvider implements ISembleProvider {
 		workspacePath: string,
 		context: vscode.ExtensionContext,
 		stateManager: CodeIndexStateManager,
-		semblePath: string = SEMBLE_DEFAULTS.DEFAULT_PATH,
 		options?: { topK?: number; content?: SembleContentType },
 	) {
 		this.workspacePath = workspacePath
 		this.context = context
 		this.stateManager = stateManager
 
 		this.config = {
-			semblePath,
 			topK: options?.topK ?? SEMBLE_DEFAULTS.DEFAULT_TOP_K,
 			content: options?.content ?? SEMBLE_DEFAULTS.DEFAULT_CONTENT,
 		}
-
-		this.cli = new SembleCLI(semblePath)
 	}
 
 	get state(): IndexingState {
 		return this._state
 	}
 
 	/**
-	 * Initializes the provider: downloads semble if needed, then validates it works.
+	 * Initializes the provider: downloads semble, then validates it works.
 	 */
 	async initialize(): Promise<void> {
 		if (this._isInitialized) {
@@ -73,21 +69,20 @@ export class SembleProvider implements ISembleProvider {
 			return
 		}
 
-		// Auto-download semble if no custom path is configured
-		if (this.config.semblePath === SEMBLE_DEFAULTS.DEFAULT_PATH) {
-			try {
-				this.stateManager.setSystemState("Indexing", "Downloading semble binary...")
-				const storageDir = this.context.globalStorageUri.fsPath
-				const binaryPath = await downloadSemble(storageDir)
-				if (binaryPath) {
-					this.cli = new SembleCLI(binaryPath)
-				}
-			} catch (error: any) {
-				this._state = "Error"
-				this.stateManager.setSystemState("Error", `Failed to download semble: ${error?.message || error}`)
-				console.error("[SembleProvider] Download failed:", error?.message || error)
-				return
+		// Download semble binary
+		try {
+			this.stateManager.setSystemState("Indexing", "Downloading semble binary...")
+			const storageDir = this.context.globalStorageUri.fsPath
+			const binaryPath = await downloadSemble(storageDir)
+			if (!binaryPath) {
+				throw new Error("Download returned no path")
 			}
+			this.cli = new SembleCLI(binaryPath)
+		} catch (error: any) {
+			this._state = "Error"
+			this.stateManager.setSystemState("Error", `Failed to download semble: ${error?.message || error}`)
+			console.error("[SembleProvider] Download failed:", error?.message || error)
+			return
 		}
 
 		// Verify the binary works
diff --git a/src/services/code-index/semble/semble-cli.ts b/src/services/code-index/semble/semble-cli.ts
@@ -6,7 +6,6 @@ import { SembleSearchResult, SembleCheckResult, SembleContentType, SEMBLE_DEFAUL
  * Wraps the `semble` CLI for programmatic access.
  *
  * The semble binary is automatically downloaded on enablement via semble-downloader.ts.
- * The semblePath should be a direct path to the executable.
  *
  * All methods spawn the semble process via child_process.spawn with array
  * arguments (no shell) to prevent shell injection.
@@ -24,7 +23,7 @@ import { SembleSearchResult, SembleCheckResult, SembleContentType, SEMBLE_DEFAUL
 export class SembleCLI {
 	private readonly semblePath: string
 
-	constructor(semblePath: string = SEMBLE_DEFAULTS.DEFAULT_PATH) {
+	constructor(semblePath: string) {
 		this.semblePath = semblePath
 	}
 
diff --git a/src/services/code-index/semble/types.ts b/src/services/code-index/semble/types.ts
@@ -41,8 +41,6 @@ export interface SembleCheckResult {
  * Configuration for the Semble provider.
  */
 export interface SembleConfig {
-	/** Path to the semble executable. Default: "semble" (uses PATH). */
-	semblePath: string
 	/** Maximum search results to return. Default: 10. */
 	topK: number
 	/** Content types to index. Default: "code". */
@@ -83,7 +81,6 @@ export interface ISembleProvider {
  * Default configuration values for Semble.
  */
 export const SEMBLE_DEFAULTS = {
-	DEFAULT_PATH: "semble",
 	DEFAULT_TOP_K: 10,
 	DEFAULT_CONTENT: "code" as SembleContentType,
 }
diff --git a/webview-ui/src/components/chat/CodeIndexPopover.tsx b/webview-ui/src/components/chat/CodeIndexPopover.tsx
@@ -81,7 +81,6 @@ interface LocalCodeIndexSettings {
 	codebaseIndexVercelAiGatewayApiKey?: string
 	codebaseIndexOpenRouterApiKey?: string
 	codebaseIndexOpenRouterSpecificProvider?: string
-	codebaseIndexSemblePath?: string
 }
 
 // Validation schema for codebase index settings
@@ -181,7 +180,6 @@ const createValidationSchema = (provider: EmbedderProvider, t: any) => {
 			// Semble requires no API keys, Qdrant URL, or model selection
 			return z.object({
 				codebaseIndexEnabled: z.boolean(),
-				codebaseIndexSemblePath: z.string().optional(),
 			})
 
 		default:
@@ -237,7 +235,6 @@ export const CodeIndexPopover: React.FC<CodeIndexPopoverProps> = ({
 		codebaseIndexVercelAiGatewayApiKey: "",
 		codebaseIndexOpenRouterApiKey: "",
 		codebaseIndexOpenRouterSpecificProvider: "",
-		codebaseIndexSemblePath: "",
 	})
 
 	// Initial settings state - stores the settings when popover opens
@@ -278,7 +275,6 @@ export const CodeIndexPopover: React.FC<CodeIndexPopoverProps> = ({
 				codebaseIndexOpenRouterApiKey: "",
 				codebaseIndexOpenRouterSpecificProvider:
 					codebaseIndexConfig.codebaseIndexOpenRouterSpecificProvider || "",
-				codebaseIndexSemblePath: codebaseIndexConfig.codebaseIndexSemblePath || "",
 			}
 			setInitialSettings(settings)
 			setCurrentSettings(settings)

Original file line number	Diff line number	Diff line change
`@@ -2500,7 +2500,6 @@ export const webviewMessageHandler = async (`
`2500`	`2500`	`codebaseIndexSearchMaxResults: settings.codebaseIndexSearchMaxResults,`
`2501`	`2501`	`codebaseIndexSearchMinScore: settings.codebaseIndexSearchMinScore,`
`2502`	`2502`	`codebaseIndexOpenRouterSpecificProvider: settings.codebaseIndexOpenRouterSpecificProvider,`
`2503`		`- codebaseIndexSemblePath: settings.codebaseIndexSemblePath,`
`2504`	`2503`	`}`
`2505`	`2504`
`2506`	`2505`	`// Save global state first`
Original file line number	Diff line number	Diff line change
`@@ -45,5 +45,4 @@ export type PreviousConfigSnapshot = {`
`45`	`45`	`openRouterSpecificProvider?: string`
`46`	`46`	`qdrantUrl?: string`
`47`	`47`	`qdrantApiKey?: string`
`48`		`- semblePath?: string`
`49`	`48`	`}`