fix(shell): prefer PowerShell 7 over legacy when no Windows profile is set (#82)

Author: proyectoauraorg

src/utils/__tests__/shell.spec.ts

@@ -1,5 +1,6 @@
 import { describe, it, expect, vi, beforeEach, afterEach } from "vitest"
 import * as vscode from "vscode"
+import { existsSync } from "fs"
 import { userInfo } from "os"
 import { getShell } from "../shell"
 
@@ -15,6 +16,11 @@ vi.mock("os", () => ({
 	userInfo: vi.fn(() => ({ shell: null })),
 }))
 
+// Mock the fs module — getWindowsShellFromVSCode probes for PowerShell 7 (pwsh.exe).
+vi.mock("fs", () => ({
+	existsSync: vi.fn(() => false),
+}))
+
 // Mock path module for testing
 vi.mock("path", async () => {
 	const actual = await vi.importActual("path")
@@ -57,6 +63,8 @@ describe("Shell Detection Tests", () => {
 
 		// Reset userInfo mock to default
 		vi.mocked(userInfo).mockReturnValue({ shell: null } as any)
+		// Default: PowerShell 7 is not installed, so the probe falls back to legacy.
+		vi.mocked(existsSync).mockReturnValue(false)
 	})
 
 	afterEach(() => {
@@ -173,11 +181,20 @@ describe("Shell Detection Tests", () => {
 			expect(getShell()).toBe("C:\\Windows\\System32\\cmd.exe")
 		})
 
-		it("defaults to Windows PowerShell when VS Code has no configured profile", () => {
-			// Modern VS Code launches PowerShell by default on Windows (issue #82), so
-			// getShell() should report PowerShell rather than falling through to cmd.exe.
+		it("defaults to PowerShell 7 when no profile is configured and pwsh.exe is installed", () => {
+			// Modern VS Code launches PowerShell by default on Windows (issue #82) and
+			// prefers PS7 when present, so getShell() should report pwsh.exe.
+			vscode.workspace.getConfiguration = () => ({ get: () => undefined }) as any
+			vi.mocked(existsSync).mockReturnValue(true)
+
+			expect(getShell()).toBe("C:\\Program Files\\PowerShell\\7\\pwsh.exe")
+		})
+
+		it("falls back to Windows PowerShell 5.1 when no profile is configured and PS7 is absent", () => {
+			// Without PS7 installed, the probe falls back to the always-present legacy
+			// PowerShell rather than cmd.exe.
 			vscode.workspace.getConfiguration = () => ({ get: () => undefined }) as any
-			vi.mocked(userInfo).mockReturnValue({ shell: "C:\\Program Files\\PowerShell\\7\\pwsh.exe" } as any)
+			vi.mocked(existsSync).mockReturnValue(false)
 
 			expect(getShell()).toBe("C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\powershell.exe")
 		})

src/utils/shell.ts

@@ -1,4 +1,5 @@
 import * as vscode from "vscode"
+import { existsSync } from "fs"
 import { userInfo } from "os"
 import * as path from "path"
 
@@ -188,13 +189,12 @@ function normalizeShellPath(path: string | string[] | undefined): string | null
 function getWindowsShellFromVSCode(): string | null {
 	const { defaultProfileName, profiles } = getWindowsTerminalConfig()
 	if (!defaultProfileName) {
-		// No explicit Windows terminal profile is configured. VS Code's built-in
-		// default on modern Windows is PowerShell (not cmd.exe), and that is the
-		// shell the integrated terminal actually launches. Mirror it here so the
-		// system prompt advertises the real shell instead of falling through to
-		// COMSPEC (cmd.exe). Windows PowerShell is always present, so it is a safe
-		// allowlisted default. See issue #82.
-		return SHELL_PATHS.POWERSHELL_LEGACY
+		// No explicit Windows terminal profile is configured. VS Code auto-detects
+		// the default on modern Windows and prefers PowerShell 7 (pwsh.exe) when it
+		// is installed, otherwise the always-present Windows PowerShell 5.1. Mirror
+		// that here so the system prompt advertises the real shell instead of falling
+		// through to COMSPEC (cmd.exe). See issue #82.
+		return existsSync(SHELL_PATHS.POWERSHELL_7) ? SHELL_PATHS.POWERSHELL_7 : SHELL_PATHS.POWERSHELL_LEGACY
 	}
 
 	const profile = profiles[defaultProfileName]