Merge branch 'main' into issue/559

Author: navedmerchant

packages/build/src/esbuild.ts

@@ -197,15 +197,23 @@ function copyEsbuildWasmFiles(nodeModulesDir: string, distDir: string): void {
 	]
 
 	for (const { src, dest } of filesToCopy) {
-		fs.copyFileSync(src, dest)
-
-		// Make CLI executable.
 		if (src.endsWith("esbuild")) {
+			// Read the esbuild binary, patch it to prevent the V8 crash (crbug.com/1201626)
+			// by eagerly initializing process.stdout.fd and process.stderr.fd on line 2
+			// before WebAssembly execution takes place.
+			let content = fs.readFileSync(src, "utf8")
+			content = content.replace(
+				/^(#!.*$)/m,
+				"$1\n// Eagerly initialize stdout/stderr to avoid V8 crash (crbug.com/1201626) inside WASM stack\nconst _ = [process.stdout.fd, process.stderr.fd];",
+			)
+			fs.writeFileSync(dest, content)
 			try {
 				fs.chmodSync(dest, 0o755)
 			} catch {
 				// Ignore chmod errors on Windows.
 			}
+		} else {
+			fs.copyFileSync(src, dest)
 		}
 	}
 

packages/types/src/__tests__/lite-llm.test.ts

@@ -0,0 +1,47 @@
+import { isLiteLLMPreserveReasoningModel, LITELLM_PRESERVE_REASONING_MODEL_IDS } from "../providers/lite-llm.js"
+
+describe("LiteLLM preserveReasoning model detection", () => {
+	it("matches every explicitly listed model id", () => {
+		for (const modelId of LITELLM_PRESERVE_REASONING_MODEL_IDS) {
+			expect(isLiteLLMPreserveReasoningModel(modelId)).toBe(true)
+		}
+	})
+
+	it("does not contain duplicate model ids", () => {
+		expect(new Set(LITELLM_PRESERVE_REASONING_MODEL_IDS).size).toBe(LITELLM_PRESERVE_REASONING_MODEL_IDS.length)
+	})
+
+	it("matches provider-prefixed routed model names by their final segment", () => {
+		expect(isLiteLLMPreserveReasoningModel("deepseek/deepseek-reasoner")).toBe(true)
+		expect(isLiteLLMPreserveReasoningModel("bedrock/moonshot.kimi-k2-thinking")).toBe(true)
+		expect(isLiteLLMPreserveReasoningModel("fireworks_ai/accounts/fireworks/models/kimi-k2p7-code")).toBe(true)
+	})
+
+	it("matches case-insensitively", () => {
+		expect(isLiteLLMPreserveReasoningModel("MiniMax-M2.7-Highspeed")).toBe(true)
+		expect(isLiteLLMPreserveReasoningModel("GLM-5.2")).toBe(true)
+	})
+
+	it("does not match model ids that merely contain a known family as a substring", () => {
+		expect(isLiteLLMPreserveReasoningModel("deepseek-v4-mini")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("mimo-v2.6")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("kimi-k2.6")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("kimi-k2.7-code")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("minimax-m4")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("minimax-m1")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("glm-4.7-flash")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("glm-4.7-flashx")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("glm-5-flash")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("glm-4.8")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("qwen3.5-plus")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("qwen3.7-mini")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("qwen3.6-max")).toBe(false)
+	})
+
+	it("does not match unrelated model names", () => {
+		expect(isLiteLLMPreserveReasoningModel("gpt-4")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("claude-3-opus")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel("")).toBe(false)
+		expect(isLiteLLMPreserveReasoningModel(undefined)).toBe(false)
+	})
+})

packages/types/src/__tests__/provider-identifiers.test.ts

@@ -0,0 +1,123 @@
+import {
+	isProviderName,
+	isRetiredProvider,
+	providerIdentifiers,
+	providerNames,
+	providerNamesSchema,
+	providerNamesWithRetiredSchema,
+	retiredProviderIdentifiers,
+	retiredProviderNames,
+	retiredProviderNamesSchema,
+} from "../index.js"
+
+const expectedProviderIdentifiers = [
+	"openrouter",
+	"vercel-ai-gateway",
+	"zoo-gateway",
+	"litellm",
+	"requesty",
+	"unbound",
+	"poe",
+	"deepseek",
+	"opencode-go",
+	"kenari",
+	"ollama",
+	"lmstudio",
+	"vscode-lm",
+	"openai",
+	"fake-ai",
+	"anthropic",
+	"bedrock",
+	"baseten",
+	"fireworks",
+	"friendli",
+	"gemini",
+	"gemini-cli",
+	"mistral",
+	"moonshot",
+	"minimax",
+	"mimo",
+	"openai-codex",
+	"openai-native",
+	"qwen-code",
+	"sambanova",
+	"vertex",
+	"xai",
+	"zai",
+]
+
+const expectedRetiredProviderIdentifiers = [
+	"cerebras",
+	"chutes",
+	"deepinfra",
+	"doubao",
+	"featherless",
+	"groq",
+	"huggingface",
+	"io-intelligence",
+	"roo",
+]
+
+describe("provider identifiers", () => {
+	it("preserves active provider serialized values", () => {
+		const identifiers = Object.values(providerIdentifiers)
+
+		expect(identifiers).toEqual(expectedProviderIdentifiers)
+		expect(new Set(identifiers).size).toBe(identifiers.length)
+	})
+
+	it("preserves retired provider serialized values", () => {
+		const identifiers = Object.values(retiredProviderIdentifiers)
+
+		expect(identifiers).toEqual(expectedRetiredProviderIdentifiers)
+		expect(new Set(identifiers).size).toBe(identifiers.length)
+	})
+
+	it("preserves provider-settings compatibility exports", () => {
+		const identifiers = Object.values(providerIdentifiers)
+		const retiredIdentifiers = Object.values(retiredProviderIdentifiers)
+
+		expect(providerNames).toEqual(identifiers)
+		expect(retiredProviderNames).toEqual(retiredIdentifiers)
+	})
+
+	it("keeps active and retired providers separate", () => {
+		const activeIdentifiers = new Set<string>(Object.values(providerIdentifiers))
+		const retiredIdentifiers = Object.values(retiredProviderIdentifiers)
+
+		expect(retiredIdentifiers.every((identifier) => !activeIdentifiers.has(identifier))).toBe(true)
+	})
+
+	it("derives runtime validation from the canonical registries", () => {
+		for (const identifier of expectedProviderIdentifiers) {
+			expect(providerNamesSchema.safeParse(identifier).success).toBe(true)
+			expect(providerNamesWithRetiredSchema.safeParse(identifier).success).toBe(true)
+		}
+
+		for (const identifier of expectedRetiredProviderIdentifiers) {
+			expect(providerNamesSchema.safeParse(identifier).success).toBe(false)
+			expect(retiredProviderNamesSchema.safeParse(identifier).success).toBe(true)
+			expect(providerNamesWithRetiredSchema.safeParse(identifier).success).toBe(true)
+		}
+
+		expect(providerNamesSchema.safeParse("unknown-provider").success).toBe(false)
+		expect(retiredProviderNamesSchema.safeParse("unknown-provider").success).toBe(false)
+		expect(providerNamesWithRetiredSchema.safeParse("unknown-provider").success).toBe(false)
+	})
+
+	it("preserves provider-settings type guards", () => {
+		for (const identifier of expectedProviderIdentifiers) {
+			expect(isProviderName(identifier)).toBe(true)
+			expect(isRetiredProvider(identifier)).toBe(false)
+		}
+
+		for (const identifier of expectedRetiredProviderIdentifiers) {
+			expect(isProviderName(identifier)).toBe(false)
+			expect(isRetiredProvider(identifier)).toBe(true)
+		}
+
+		expect(isProviderName("unknown-provider")).toBe(false)
+		expect(isProviderName(undefined)).toBe(false)
+		expect(isRetiredProvider("unknown-provider")).toBe(false)
+	})
+})

packages/types/src/index.ts

@@ -18,6 +18,7 @@ export * from "./mcp.js"
 export * from "./message.js"
 export * from "./mode.js"
 export * from "./model.js"
+export * from "./provider-identifiers.js"
 export * from "./provider-settings.js"
 export * from "./task.js"
 export * from "./todo.js"

packages/types/src/provider-identifiers.ts

@@ -0,0 +1,57 @@
+/**
+ * Canonical provider identifiers.
+ *
+ * Values in this registry are persisted in settings and must remain stable.
+ */
+export const providerIdentifiers = {
+	openrouter: "openrouter",
+	vercelAiGateway: "vercel-ai-gateway",
+	zooGateway: "zoo-gateway",
+	litellm: "litellm",
+	requesty: "requesty",
+	unbound: "unbound",
+	poe: "poe",
+	deepseek: "deepseek",
+	opencodeGo: "opencode-go",
+	kenari: "kenari",
+	ollama: "ollama",
+	lmstudio: "lmstudio",
+	vscodeLm: "vscode-lm",
+	openai: "openai",
+	fakeAi: "fake-ai",
+	anthropic: "anthropic",
+	bedrock: "bedrock",
+	baseten: "baseten",
+	fireworks: "fireworks",
+	friendli: "friendli",
+	gemini: "gemini",
+	geminiCli: "gemini-cli",
+	mistral: "mistral",
+	moonshot: "moonshot",
+	minimax: "minimax",
+	mimo: "mimo",
+	openaiCodex: "openai-codex",
+	openaiNative: "openai-native",
+	qwenCode: "qwen-code",
+	sambanova: "sambanova",
+	vertex: "vertex",
+	xai: "xai",
+	zai: "zai",
+} as const
+
+export type ProviderIdentifier = (typeof providerIdentifiers)[keyof typeof providerIdentifiers]
+
+/** Provider identifiers retained only for compatibility with existing settings. */
+export const retiredProviderIdentifiers = {
+	cerebras: "cerebras",
+	chutes: "chutes",
+	deepinfra: "deepinfra",
+	doubao: "doubao",
+	featherless: "featherless",
+	groq: "groq",
+	huggingface: "huggingface",
+	ioIntelligence: "io-intelligence",
+	roo: "roo",
+} as const
+
+export type RetiredProviderIdentifier = (typeof retiredProviderIdentifiers)[keyof typeof retiredProviderIdentifiers]

packages/types/src/provider-settings.ts

@@ -2,6 +2,12 @@ import { z } from "zod"
 
 import { modelInfoSchema, reasoningEffortSettingSchema, verbosityLevelsSchema, serviceTierSchema } from "./model.js"
 import { codebaseIndexProviderSchema } from "./codebase-index.js"
+import {
+	providerIdentifiers,
+	retiredProviderIdentifiers,
+	type ProviderIdentifier,
+	type RetiredProviderIdentifier,
+} from "./provider-identifiers.js"
 import {
 	anthropicModels,
 	basetenModels,
@@ -111,32 +117,7 @@ export const isFauxProvider = (key: string): key is FauxProvider => fauxProvider
  * ProviderName
  */
 
-export const providerNames = [
-	...dynamicProviders,
-	...localProviders,
-	...internalProviders,
-	...customProviders,
-	...fauxProviders,
-	"anthropic",
-	"bedrock",
-	"baseten",
-	"deepseek",
-	"fireworks",
-	"friendli",
-	"gemini",
-	"gemini-cli",
-	"mistral",
-	"moonshot",
-	"minimax",
-	"mimo",
-	"openai-codex",
-	"openai-native",
-	"qwen-code",
-	"sambanova",
-	"vertex",
-	"xai",
-	"zai",
-] as const
+export const providerNames = Object.values(providerIdentifiers) as [ProviderIdentifier, ...ProviderIdentifier[]]
 
 export const providerNamesSchema = z.enum(providerNames)
 
@@ -149,17 +130,10 @@ export const isProviderName = (key: unknown): key is ProviderName =>
  * RetiredProviderName
  */
 
-export const retiredProviderNames = [
-	"cerebras",
-	"chutes",
-	"deepinfra",
-	"doubao",
-	"featherless",
-	"groq",
-	"huggingface",
-	"io-intelligence",
-	"roo",
-] as const
+export const retiredProviderNames = Object.values(retiredProviderIdentifiers) as [
+	RetiredProviderIdentifier,
+	...RetiredProviderIdentifier[],
+]
 
 export const retiredProviderNamesSchema = z.enum(retiredProviderNames)