fix(openai): always fail on codex Responses-API error events (#87)

Error/failed events without error/message fields were silently ignored,
risking continued processing of a broken stream. Throw unconditionally on
response.error/error/response.failed (with an Unknown error/failure fallback).
Adds a test for the no-details case.

Author: proyectoauraorg

src/api/providers/__tests__/openai-codex-responses.spec.ts

@@ -515,5 +515,27 @@ describe("OpenAiHandler - Codex model detection", () => {
 				}
 			}).rejects.toThrow("Responses API error: Something went wrong")
 		})
+
+		it("throws on an error event even when it carries no error/message details", async () => {
+			handler = new OpenAiHandler({
+				openAiApiKey: "test-key",
+				openAiModelId: "gpt-5.3-codex",
+				openAiUseAzure: true,
+			})
+
+			mockResponsesCreate.mockResolvedValue({
+				[Symbol.asyncIterator]: async function* () {
+					yield { type: "response.failed" }
+				},
+			})
+
+			await expect(async () => {
+				for await (const _chunk of handler.createMessage("System", [{ role: "user", content: "Hello" }], {
+					taskId: "test",
+				})) {
+					// consume
+				}
+			}).rejects.toThrow("Response failed: Unknown failure")
+		})
 	})
 })

src/api/providers/openai.ts

@@ -836,22 +836,16 @@ export class OpenAiHandler extends BaseProvider implements SingleCompletionHandl
 					continue
 				}
 
-				// Handle error events
+				// Handle error events. Always fail on an error/failed event type, even
+				// when it carries no `error`/`message`, so we never keep consuming a
+				// stream the API has already reported as broken.
 				if (event?.type === "response.error" || event?.type === "error") {
-					if (event.error || event.message) {
-						throw new Error(
-							`Responses API error: ${event.error?.message || event.message || "Unknown error"}`,
-						)
-					}
+					throw new Error(`Responses API error: ${event.error?.message || event.message || "Unknown error"}`)
 				}
 
 				// Handle failed event
 				if (event?.type === "response.failed") {
-					if (event.error || event.message) {
-						throw new Error(
-							`Response failed: ${event.error?.message || event.message || "Unknown failure"}`,
-						)
-					}
+					throw new Error(`Response failed: ${event.error?.message || event.message || "Unknown failure"}`)
 				}
 
 				// Fallback for older formats