fix(error-interception): add logging to silent error paths

Author: Zoo (VP)

src/core/assistant-message/presentAssistantMessage.ts

@@ -124,7 +124,7 @@ export async function presentAssistantMessage(cline: Task) {
 			// their original name in API history
 			const mcpBlock = block as McpToolUse
 			const interceptor = toolErrorInterceptor
-	
+
 			if (cline.didRejectTool) {
 				// For native protocol, we must send a tool_result for every tool_use to avoid API errors
 				const toolCallId = mcpBlock.id
@@ -258,7 +258,7 @@ export async function presentAssistantMessage(cline: Task) {
 				)
 				rawPushToolResult(formatResponse.toolError(errorString))
 			}
-	
+
 			const { decoratedHandleError: handleError, decoratedPushToolResult: pushToolResult } =
 				interceptor.createInterceptor(
 					cline,
@@ -391,8 +391,11 @@ export async function presentAssistantMessage(cline: Task) {
 					) {
 						;(cline as any).recordToolError((block as any).name as ToolName, errorMessage)
 					}
-				} catch {
-					// Best-effort only
+				} catch (recordErr) {
+					console.warn(
+						"[ErrorInterception] Failed to record tool error:",
+						recordErr instanceof Error ? recordErr.message : recordErr,
+					)
 				}
 				cline.consecutiveMistakeCount++
 				await cline.say("error", errorMessage)
@@ -516,20 +519,23 @@ export async function presentAssistantMessage(cline: Task) {
 					// which is a distinct failure pattern from missing args.
 					const parseErrorMessage = NativeToolCallParser.consumeParseError(toolCallId)
 					const isInvalidJson = parseErrorMessage !== undefined
-	
+
 					const errorMessage = isInvalidJson
 						? `Invalid tool call for '${block.name}': arguments could not be parsed as JSON. ` +
 							`This usually means multiple JSON objects were concatenated into a single arguments string.`
 						: `Invalid tool call for '${block.name}': missing nativeArgs. ` +
 							`This usually means the model streamed invalid or incomplete arguments and the call could not be finalized.`
-	
+
 					cline.consecutiveMistakeCount++
 					try {
 						cline.recordToolError(block.name as ToolName, errorMessage)
-					} catch {
-						// Best-effort only
+					} catch (recordErr) {
+						console.warn(
+							"[ErrorInterception] Failed to record tool error:",
+							recordErr instanceof Error ? recordErr.message : recordErr,
+						)
 					}
-	
+
 					// Convert missing nativeArgs into a structured guided payload.
 					// When a JSON.parse error was recorded, route to the
 					// INVALID_JSON_ARGUMENTS pattern; otherwise fall back to
@@ -540,11 +546,9 @@ export async function presentAssistantMessage(cline: Task) {
 						taskId: cline.taskId,
 						toolCallId,
 						toolName: block.name,
-						metadata: isInvalidJson
-							? { invalidJsonArguments: true }
-							: { missingNativeArgs: true },
+						metadata: isInvalidJson ? { invalidJsonArguments: true } : { missingNativeArgs: true },
 					})
-	
+
 					// Push tool_result directly without setting didAlreadyUseTool so streaming can
 					// continue gracefully.
 					const missingArgsGuide = getTaskErrorState(cline).consumePendingNativeProtocolGuide()
@@ -555,7 +559,7 @@ export async function presentAssistantMessage(cline: Task) {
 						content: missingArgsGuide ? `${missingArgsBase}\n\n${missingArgsGuide}` : missingArgsBase,
 						is_error: true,
 					})
-	
+
 					break
 				}
 			}
@@ -592,7 +596,7 @@ export async function presentAssistantMessage(cline: Task) {
 				if (pendingGuide) {
 					resultContent = `${resultContent}\n\n${pendingGuide}`
 				}
-	
+
 				// Merge approval feedback into tool result (GitHub #10465)
 				if (approvalFeedback) {
 					const feedbackText = formatResponse.toolApprovedWithFeedback(approvalFeedback.text)
@@ -677,7 +681,7 @@ export async function presentAssistantMessage(cline: Task) {
 
 				rawPushToolResult(formatResponse.toolError(errorString))
 			}
-	
+
 			const { decoratedHandleError: handleError, decoratedPushToolResult: pushToolResult } =
 				interceptor.createInterceptor(
 					cline,
@@ -708,7 +712,7 @@ export async function presentAssistantMessage(cline: Task) {
 					})
 				}
 			}
-	
+
 			// Structural preflight: detect malformed native tool arguments before
 			// approval or execution. CWD_OBJECT_MISUSE and NESTED_PARAM_OVERFLOW
 			// signals block the malformed call and return exactly one guided
@@ -721,7 +725,7 @@ export async function presentAssistantMessage(cline: Task) {
 						: []),
 					validateNestedParams(block.nativeArgs as Record<string, unknown>, String(block.name)),
 				].filter((s): s is NonNullable<typeof s> => s != null)
-	
+
 				if (structuralSignals.length > 0) {
 					const signal = structuralSignals[0]
 					const variant = (signal.metadata?.variant as string | undefined) ?? "STRUCTURAL_MISUSE"
@@ -735,7 +739,7 @@ export async function presentAssistantMessage(cline: Task) {
 					taskErrorState.setFingerprint("PARAM_TYPE_MISMATCH", fingerprint)
 					const occurrence = taskErrorState.incrementOccurrence("PARAM_TYPE_MISMATCH")
 					const circuitOpen = taskErrorState.isOpen("PARAM_TYPE_MISMATCH")
-	
+
 					const parameter = (signal.metadata?.parameter as string | undefined) ?? "unknown"
 					const errorMessage = circuitOpen
 						? `[MODEL_STUCK_LOOP] The malformed '${String(block.name)}' call has failed ${occurrence} times with the same structural pattern (${variant} on parameter '${parameter}'). Stop retrying this invocation shape. Continue with a different tool or strategy.`
@@ -744,14 +748,17 @@ export async function presentAssistantMessage(cline: Task) {
 							: variant === "CWD_OBJECT_MISUSE"
 								? `[CWD_OBJECT_MISUSE] execute_command.cwd must be a single directory string (or omitted). A non-string value (type: ${String(signal.metadata?.actualType)}) was provided, likely because another tool-call object was nested inside it. Submit exactly one native execute_command with 'command' at the top level and 'cwd' as a workspace path string or omitted.`
 								: `[NESTED_PARAM_OVERFLOW] The '${String(block.name)}' parameter '${parameter}' contains a nested tool invocation object (${String(signal.metadata?.signature ?? "unknown-signature")}). Issue each intended tool as a separate native tool call with only its own top-level parameters.`
-	
+
 					cline.consecutiveMistakeCount++
 					try {
 						cline.recordToolError(String(block.name) as ToolName, errorMessage)
-					} catch {
-						// Best-effort only
+					} catch (recordErr) {
+						console.warn(
+							"[ErrorInterception] Failed to record tool error:",
+							recordErr instanceof Error ? recordErr.message : recordErr,
+						)
 					}
-	
+
 					const guided = interceptor.transformError(cline, {
 						source: "validation",
 						stage: "preflight",
@@ -760,7 +767,7 @@ export async function presentAssistantMessage(cline: Task) {
 						toolName: String(block.name),
 						metadata: { ...signal.metadata, structuralPreflight: true, occurrence, circuitOpen },
 					})
-	
+
 					const structuralGuide = taskErrorState.consumePendingNativeProtocolGuide()
 					const structuralBase = guided ?? formatResponse.toolError(errorMessage)
 					cline.pushToolResultToUserContent({
@@ -769,11 +776,11 @@ export async function presentAssistantMessage(cline: Task) {
 						content: structuralGuide ? `${structuralBase}\n\n${structuralGuide}` : structuralBase,
 						is_error: true,
 					})
-	
+
 					break
 				}
 			}
-	
+
 			// Validate tool use before execution - ONLY for complete (non-partial) blocks.
 			// Validating partial blocks would cause validation errors to be thrown repeatedly
 			// during streaming, pushing multiple tool_results for the same tool_use_id and
@@ -844,7 +851,7 @@ export async function presentAssistantMessage(cline: Task) {
 						content: validationGuide ? `${validationBase}\n\n${validationGuide}` : validationBase,
 						is_error: true,
 					})
-	
+
 					break
 				}
 			}
@@ -865,7 +872,7 @@ export async function presentAssistantMessage(cline: Task) {
 						signalMetadata.repetitionCount = blockDetails.consecutiveCount
 						signalMetadata.fingerprint = blockDetails.fingerprint
 					}
-	
+
 					const guided = interceptor.transformError(cline, {
 						source: "repetition",
 						stage: "result",
@@ -874,11 +881,11 @@ export async function presentAssistantMessage(cline: Task) {
 						toolName: block.name,
 						metadata: signalMetadata,
 					})
-	
+
 					if (guided) {
 						pushToolResult(guided)
 					}
-	
+
 					// Handle repetition similar to mistake_limit_reached pattern.
 					const { response, text, images } = await cline.ask(
 						repetitionCheck.askUser.messageKey as ClineAsk,

src/core/tools/error-interception/ToolErrorInterceptor.ts

@@ -251,6 +251,9 @@ export class ToolErrorInterceptor {
 	): ToolResponse | undefined {
 		const classification = classifyError(signal)
 		if (classification.category === "UNCLASSIFIED" || classification.patternId === "EI/UNCLASSIFIED/001") {
+			console.warn(
+				`[ErrorInterceptor] Unclassified error pattern — passing through without guidance. tool=${signal.toolName ?? "unknown"} patternId=${classification.patternId}`,
+			)
 			return undefined
 		}
 
@@ -294,7 +297,8 @@ export class ToolErrorInterceptor {
 			if (trimmed.startsWith("<error_details>")) return true
 			if (trimmed.startsWith("File does not exist")) return true
 			if (trimmed.startsWith("cannot find path") || trimmed.startsWith("Path not found")) return true
-			if (trimmed.startsWith("apply_diff failed") || trimmed.includes("no sufficiently similar match")) return true
+			if (trimmed.startsWith("apply_diff failed") || trimmed.includes("no sufficiently similar match"))
+				return true
 			return false
 		}