Address Novita provider review feedback

Author: Alex-yang00

README.md

@@ -56,7 +56,6 @@ for this exact support, so if you are having problems or if you have question, j
 ## What's New in v3.62.0
 
 - **GLM-5.2 support** — the latest GLM model is now available in your provider settings
-- **Novita AI support** — The AI-Native Cloud for Builders and Agents: run models, scale GPUs, and build AI agents, all on one platform
 - **OpenCode-Go improvements** — native model parameters, Anthropic-format routing, and a context-token fix for more reliable responses
 - **Tool-writer mode** — a new specialized mode for writing and maintaining tool definitions, now available in the Marketplace
 - **LiteLLM session header** — forward taskId as X-Zoo-Session-ID request header for better request tracing
@@ -88,7 +87,7 @@ for this exact support, so if you are having problems or if you have question, j
 - [简体中文](locales/zh-CN/README.md)
 - [繁體中文](locales/zh-TW/README.md)
 - ...
-    </details>
+      </details>
 
 ---
 

apps/cli/README.md

@@ -76,9 +76,11 @@ By default, the CLI auto-approves actions and runs in interactive TUI mode:
 
 ```bash
 export OPENROUTER_API_KEY=sk-or-v1-...
-# or use Novita AI, the AI-native cloud for builders and agents:
-export NOVITA_API_KEY=...
 
+roo "What is this project?" -w ~/Documents/my-project
+
+# Or use Novita AI explicitly:
+export NOVITA_API_KEY=...
 roo "What is this project?" --provider novita -w ~/Documents/my-project
 ```
 
@@ -237,8 +239,7 @@ The CLI will look for API keys in environment variables if not provided via `--a
 # Run directly from source (no build required)
 pnpm dev --provider openrouter --api-key $OPENROUTER_API_KEY --print "Hello"
 
-# Novita AI: The AI-Native Cloud for Builders and Agents.
-# Run models, scale GPUs, and build AI agents, all on one platform.
+# Novita AI (OpenAI-compatible)
 pnpm dev --provider novita --api-key $NOVITA_API_KEY --model moonshotai/kimi-k2.7-code --print "Hello"
 
 # Run tests

apps/vscode-e2e/src/suite/providers/novita.test.ts

@@ -181,9 +181,11 @@ async function runNovitaToolProbe(
 	let taskId: string | undefined
 
 	try {
+		const novitaApiKey = aimockUrl && !isRecord ? "mock-key" : NOVITA_API_KEY
+
 		await api.setConfiguration({
 			apiProvider: "novita" as const,
-			novitaApiKey: aimockUrl && !isRecord ? "mock-key" : NOVITA_API_KEY!,
+			...(novitaApiKey && { novitaApiKey }),
 			...(aimockUrl && { novitaBaseUrl: `${aimockUrl}/v1` }),
 			apiModelId: modelId,
 		})
@@ -244,9 +246,7 @@ async function runNovitaToolProbe(
 				mistakeLimitReached,
 				completionText,
 				usedReadFile: usedReadFile || transcript.some((line) => line.includes(fileName)),
-				requests: requests.filter(
-					(request) => request.model === modelId && (!request.probeTag || request.probeTag === probeTag),
-				),
+				requests: requests.filter((request) => request.model === modelId && request.probeTag === probeTag),
 				transcript,
 			},
 		}
@@ -275,7 +275,9 @@ suite("Novita provider", function () {
 	const requests: CapturedNovitaRequest[] = []
 
 	setup(function () {
-		if (!process.env.AIMOCK_URL && !NOVITA_API_KEY) {
+		const needsRealNovitaKey = process.env.AIMOCK_RECORD === "true" || !process.env.AIMOCK_URL
+
+		if (needsRealNovitaKey && !NOVITA_API_KEY) {
 			this.skip()
 		}
 	})
@@ -293,13 +295,15 @@ suite("Novita provider", function () {
 
 		const aimockUrl = process.env.AIMOCK_URL
 		const isRecord = process.env.AIMOCK_RECORD === "true"
+		const openRouterApiKey = aimockUrl
+			? isRecord
+				? (process.env.OPENROUTER_API_KEY ?? "mock-key")
+				: "mock-key"
+			: process.env.OPENROUTER_API_KEY
+
 		await globalThis.api.setConfiguration({
 			apiProvider: "openrouter" as const,
-			openRouterApiKey: aimockUrl
-				? isRecord
-					? (process.env.OPENROUTER_API_KEY ?? "mock-key")
-					: "mock-key"
-				: process.env.OPENROUTER_API_KEY!,
+			...(openRouterApiKey && { openRouterApiKey }),
 			openRouterModelId: "openai/gpt-4.1",
 			...(aimockUrl && { openRouterBaseUrl: `${aimockUrl}/v1` }),
 		})
@@ -320,9 +324,6 @@ suite("Novita provider", function () {
 		assert.strictEqual(result.aborted, false, `Novita task should not abort.\n${diagnostics}`)
 		assert.strictEqual(result.noToolErrors, 0, `Novita should not hit MODEL_NO_TOOLS_USED.\n${diagnostics}`)
 		assert.ok(result.usedReadFile, `Novita should use read_file for the marker file.\n${diagnostics}`)
-		assert.ok(
-			!result.completionText || result.completionText === marker,
-			`Novita should not return an incorrect marker.\n${diagnostics}`,
-		)
+		assert.strictEqual(result.completionText, marker, `Novita should return the exact marker.\n${diagnostics}`)
 	})
 })

packages/types/src/__tests__/provider-settings.test.ts

@@ -1,4 +1,4 @@
-import { getApiProtocol } from "../provider-settings.js"
+import { getApiProtocol, providerSettingsSchema } from "../provider-settings.js"
 import { getProviderDefaultModelId, novitaDefaultModelId } from "../providers/index.js"
 
 describe("getApiProtocol", () => {
@@ -94,6 +94,29 @@ describe("getApiProtocol", () => {
 		it("returns the Novita default model ID", () => {
 			expect(getProviderDefaultModelId("novita")).toBe(novitaDefaultModelId)
 		})
+
+		it("validates Novita base URLs", () => {
+			expect(
+				providerSettingsSchema.safeParse({
+					apiProvider: "novita",
+					novitaBaseUrl: "https://api.novita.ai/openai",
+				}).success,
+			).toBe(true)
+
+			expect(
+				providerSettingsSchema.safeParse({
+					apiProvider: "novita",
+					novitaBaseUrl: "",
+				}).data?.novitaBaseUrl,
+			).toBeUndefined()
+
+			expect(
+				providerSettingsSchema.safeParse({
+					apiProvider: "novita",
+					novitaBaseUrl: "not-a-url",
+				}).success,
+			).toBe(false)
+		})
 	})
 
 	describe("Edge cases", () => {

packages/types/src/provider-settings.ts

@@ -334,7 +334,7 @@ const moonshotSchema = apiModelIdProviderModelSchema.extend({
 })
 
 const novitaSchema = apiModelIdProviderModelSchema.extend({
-	novitaBaseUrl: z.string().optional(),
+	novitaBaseUrl: z.preprocess((value) => (value === "" ? undefined : value), z.string().url().optional()),
 	novitaApiKey: z.string().optional(),
 })
 

src/api/providers/__tests__/novita.spec.ts

@@ -54,6 +54,16 @@ describe("NovitaHandler", () => {
 		expect(handler.getModel().info).toBe(novitaModels[novitaDefaultModelId])
 	})
 
+	it("uses a sentinel API key when no Novita API key is configured", () => {
+		new NovitaHandler({})
+
+		expect(mockCreateOpenAICompatible).toHaveBeenCalledWith(
+			expect.objectContaining({
+				apiKey: "not-provided",
+			}),
+		)
+	})
+
 	it("returns the requested model ID with default model info for unknown models", () => {
 		const handler = new NovitaHandler({
 			...mockOptions,
@@ -73,6 +83,7 @@ describe("NovitaHandler", () => {
 		})
 
 		const model = handler.getModel()
+		expect((handler as unknown as { config: { modelMaxTokens?: number } }).config.modelMaxTokens).toBe(2048)
 		expect(model.temperature).toBe(0.3)
 	})
 })

webview-ui/src/components/settings/providers/Novita.tsx

@@ -32,6 +32,7 @@ export const Novita = ({ apiConfiguration, setApiConfigurationField }: NovitaPro
 			<div>
 				<VSCodeTextField
 					value={apiConfiguration?.novitaBaseUrl || "https://api.novita.ai/openai"}
+					type="url"
 					onInput={handleInputChange("novitaBaseUrl")}
 					placeholder="https://api.novita.ai/openai"
 					className="w-full">

webview-ui/src/components/settings/providers/__tests__/Novita.spec.tsx

@@ -34,7 +34,9 @@ describe("Novita provider settings", () => {
 		render(<Novita apiConfiguration={{} as ProviderSettings} setApiConfigurationField={vi.fn()} />)
 
 		expect(screen.getByLabelText("settings:providers.novitaBaseUrl")).toHaveValue("https://api.novita.ai/openai")
+		expect(screen.getByLabelText("settings:providers.novitaBaseUrl")).toHaveAttribute("type", "url")
 		expect(screen.getByLabelText("settings:providers.novitaApiKey")).toHaveValue("")
+		expect(screen.getByLabelText("settings:providers.novitaApiKey")).toHaveAttribute("type", "password")
 		expect(screen.getByRole("link", { name: "settings:providers.getNovitaApiKey" })).toHaveAttribute(
 			"href",
 			"https://novita.ai/settings/key-management",

webview-ui/src/components/ui/hooks/__tests__/useSelectedModel.spec.ts

@@ -820,5 +820,19 @@ describe("useSelectedModel", () => {
 			expect(result.current.id).toBe("minimax/minimax-m3")
 			expect(result.current.info).toEqual(novitaModels["minimax/minimax-m3"])
 		})
+
+		it("should return undefined model info for unknown Novita model IDs", () => {
+			const apiConfiguration: ProviderSettings = {
+				apiProvider: "novita",
+				apiModelId: "provider/new-model",
+			}
+
+			const wrapper = createWrapper()
+			const { result } = renderHook(() => useSelectedModel(apiConfiguration), { wrapper })
+
+			expect(result.current.provider).toBe("novita")
+			expect(result.current.id).toBe("provider/new-model")
+			expect(result.current.info).toBeUndefined()
+		})
 	})
 })