fix(terminal): hide inline profile picker when inline execution is off

The terminal-profile dropdown only affects inline execution, which is active
when shell integration is disabled. It previously stayed visible and editable
even when inline mode was off, where it has no effect. Guard it with
terminalShellIntegrationDisabled (defaulting to shown, matching the checkbox),
mirroring the inline-only settings below. Addresses PR #277 review (edelauna).

Author: proyectoauraorg

webview-ui/src/components/settings/TerminalSettings.tsx

@@ -151,37 +151,43 @@ export const TerminalSettings = ({
 						</div>
 					</div>
 					<div className="flex flex-col gap-3 pl-3 border-l-2 border-vscode-button-background">
-						<SearchableSetting
-							settingId="terminal-profile"
-							section="terminal"
-							label={t("settings:terminal.profile.label")}>
-							<label className="block font-medium mb-1">{t("settings:terminal.profile.label")}</label>
-							<Select
-								value={terminalProfile || DEFAULT_PROFILE_VALUE}
-								onValueChange={(value) =>
-									setCachedStateField(
-										"terminalProfile",
-										value === DEFAULT_PROFILE_VALUE ? undefined : value,
-									)
-								}>
-								<SelectTrigger className="w-full" data-testid="terminal-profile-dropdown">
-									<SelectValue placeholder={t("settings:common.select")} />
-								</SelectTrigger>
-								<SelectContent>
-									<SelectItem value={DEFAULT_PROFILE_VALUE}>
-										{t("settings:terminal.profile.default")}
-									</SelectItem>
-									{profileNames.map((name) => (
-										<SelectItem key={name} value={name}>
-											{name}
+						{/* The profile picker only affects inline execution, which is active when shell
+						    integration is disabled. Hide it otherwise so it isn't shown but ineffective
+						    (mirrors the inline-only settings guarded below). Defaults to shown, matching
+						    the checkbox's `?? true`. See PR #277 review. */}
+						{(terminalShellIntegrationDisabled ?? true) && (
+							<SearchableSetting
+								settingId="terminal-profile"
+								section="terminal"
+								label={t("settings:terminal.profile.label")}>
+								<label className="block font-medium mb-1">{t("settings:terminal.profile.label")}</label>
+								<Select
+									value={terminalProfile || DEFAULT_PROFILE_VALUE}
+									onValueChange={(value) =>
+										setCachedStateField(
+											"terminalProfile",
+											value === DEFAULT_PROFILE_VALUE ? undefined : value,
+										)
+									}>
+									<SelectTrigger className="w-full" data-testid="terminal-profile-dropdown">
+										<SelectValue placeholder={t("settings:common.select")} />
+									</SelectTrigger>
+									<SelectContent>
+										<SelectItem value={DEFAULT_PROFILE_VALUE}>
+											{t("settings:terminal.profile.default")}
 										</SelectItem>
-									))}
-								</SelectContent>
-							</Select>
-							<div className="text-vscode-descriptionForeground text-sm mt-1">
-								{t("settings:terminal.profile.description")}
-							</div>
-						</SearchableSetting>
+										{profileNames.map((name) => (
+											<SelectItem key={name} value={name}>
+												{name}
+											</SelectItem>
+										))}
+									</SelectContent>
+								</Select>
+								<div className="text-vscode-descriptionForeground text-sm mt-1">
+									{t("settings:terminal.profile.description")}
+								</div>
+							</SearchableSetting>
+						)}
 
 						<SearchableSetting
 							settingId="terminal-shell-integration-disabled"

webview-ui/src/components/settings/__tests__/TerminalSettings.profile.spec.tsx

@@ -72,11 +72,13 @@ describe("TerminalSettings inline terminal profile (#119)", () => {
 		postMessageMock.mockClear()
 	})
 
+	// Inline execution is active when shell integration is disabled, which is when the
+	// profile picker is shown; render in that state for the picker-behavior tests.
 	const setup = (terminalProfile?: string) => {
 		const setCachedStateField = vi.fn()
 		render(
 			<TerminalSettings
-				terminalShellIntegrationDisabled={false}
+				terminalShellIntegrationDisabled={true}
 				terminalProfile={terminalProfile}
 				setCachedStateField={setCachedStateField}
 			/>,
@@ -123,4 +125,12 @@ describe("TerminalSettings inline terminal profile (#119)", () => {
 
 		expect(setCachedStateField).toHaveBeenCalledWith("terminalProfile", undefined)
 	})
+
+	it("hides the profile picker when inline execution is off (shell integration enabled)", () => {
+		render(<TerminalSettings terminalShellIntegrationDisabled={false} setCachedStateField={vi.fn()} />)
+		// The picker is inline-only: with shell integration enabled it must not render.
+		expect(screen.queryByTestId("option-__default__")).not.toBeInTheDocument()
+		// But the names are still requested on mount (cheap, harmless, keeps state warm).
+		expect(postMessageMock.mock.calls.map((c) => c[0]?.type)).toContain("requestTerminalProfiles")
+	})
 })