fix(terminal): resolve profile path[] to first existing candidate (#119)

VS Code selects the first terminal-profile path candidate that exists on
disk; mirror that instead of always taking index 0, falling back to the
first non-empty candidate when none exist. Addresses CodeRabbit review on #277.

Author: proyectoauraorg

src/integrations/terminal/Terminal.ts

@@ -1,3 +1,5 @@
+import { existsSync } from "fs"
+
 import * as vscode from "vscode"
 import pWaitFor from "p-wait-for"
 
@@ -277,9 +279,12 @@ export class Terminal extends BaseTerminal {
 			return undefined
 		}
 
-		// A `path` may be a single string or an array of candidate paths (VS Code
-		// picks the first that exists). We pass the first candidate to createTerminal.
-		const pathValue = Array.isArray(profile.path) ? profile.path[0] : profile.path
+		// A `path` may be a single string or an array of candidate paths. VS Code
+		// picks the first candidate that exists on disk, so mirror that: prefer the
+		// first existing path, otherwise fall back to the first non-empty candidate.
+		const candidates = Array.isArray(profile.path) ? profile.path : [profile.path]
+		const nonEmpty = candidates.filter((p): p is string => typeof p === "string" && p.length > 0)
+		const pathValue = nonEmpty.find((p) => existsSync(p)) ?? nonEmpty[0]
 
 		if (!pathValue) {
 			// Profiles defined only by `source` (e.g. "PowerShell") can't be mapped to

src/integrations/terminal/__tests__/TerminalProfile.spec.ts

@@ -1,5 +1,7 @@
 // npx vitest run src/integrations/terminal/__tests__/TerminalProfile.spec.ts
 
+import { existsSync } from "fs"
+
 import * as vscode from "vscode"
 
 import { Terminal } from "../Terminal"
@@ -9,6 +11,12 @@ vi.mock("execa", () => ({
 	execa: vi.fn(),
 }))
 
+vi.mock("fs", () => ({
+	existsSync: vi.fn(() => false),
+}))
+
+const mockedExistsSync = existsSync as unknown as ReturnType<typeof vi.fn>
+
 describe("Terminal inline terminal profile (#119)", () => {
 	// VS Code's getConfiguration/createTerminal are overloaded, so the precise
 	// spy MockInstance type isn't worth fighting in a test — `any` keeps it simple.
@@ -44,6 +52,9 @@ describe("Terminal inline terminal profile (#119)", () => {
 
 	beforeEach(() => {
 		createTerminalSpy = vi.spyOn(vscode.window, "createTerminal").mockImplementation(() => mockTerminal())
+		// Default: no candidate path exists on disk unless a test says otherwise.
+		mockedExistsSync.mockReset()
+		mockedExistsSync.mockReturnValue(false)
 		// Reset to default (unset) before each test.
 		Terminal.setTerminalProfile(undefined)
 	})
@@ -117,14 +128,34 @@ describe("Terminal inline terminal profile (#119)", () => {
 			})
 		})
 
-		it("uses the first path candidate when path is an array", () => {
+		it("picks the first existing path candidate when path is an array", () => {
 			stubProfiles({
 				windows: {
 					"Git Bash": {
 						path: ["C:\\missing\\bash.exe", "C:\\Program Files\\Git\\bin\\bash.exe"],
 					},
 				},
 			})
+			// Only the second candidate exists on disk; VS Code would pick it.
+			mockedExistsSync.mockImplementation((p: string) => p === "C:\\Program Files\\Git\\bin\\bash.exe")
+
+			Terminal.setTerminalProfile("Git Bash")
+
+			expect(Terminal.getProfileShell("win32")).toEqual({
+				shellPath: "C:\\Program Files\\Git\\bin\\bash.exe",
+				shellArgs: undefined,
+			})
+		})
+
+		it("falls back to the first non-empty candidate when none of the paths exist", () => {
+			stubProfiles({
+				windows: {
+					"Git Bash": {
+						path: ["C:\\missing\\bash.exe", "C:\\also-missing\\bash.exe"],
+					},
+				},
+			})
+			// existsSync defaults to false for every candidate.
 
 			Terminal.setTerminalProfile("Git Bash")