test(dcg): cover settings installation paths

Author: navedmerchant

src/core/webview/__tests__/webviewMessageHandler.spec.ts

@@ -26,6 +26,10 @@ vi.mock("../../../services/command/commands", () => ({
 	getCommands: vi.fn(),
 }))
 
+vi.mock("../../../services/destructive-command-guard", () => ({
+	ensureDcgInstalled: vi.fn(),
+}))
+
 vi.mock("@anthropic-ai/vertex-sdk", () => ({
 	AnthropicVertex: vi.fn(),
 }))
@@ -58,6 +62,7 @@ import type { ClineProvider } from "../ClineProvider"
 import { flushModels, getModels } from "../../../api/providers/fetchers/modelCache"
 import { getLMStudioModels } from "../../../api/providers/fetchers/lmstudio"
 import { getCommands } from "../../../services/command/commands"
+import { ensureDcgInstalled } from "../../../services/destructive-command-guard"
 import {
 	handleCreateRule,
 	handleDeleteRule,
@@ -1098,6 +1103,62 @@ describe("webviewMessageHandler - mcpEnabled", () => {
 	})
 })
 
+describe("webviewMessageHandler - destructiveCommandGuardEnabled", () => {
+	beforeEach(() => {
+		vi.clearAllMocks()
+		vi.mocked(ensureDcgInstalled).mockResolvedValue("/mock/global/storage/dcg")
+	})
+
+	it("installs and persists destructive command guard when enabled", async () => {
+		await webviewMessageHandler(mockClineProvider, {
+			type: "updateSettings",
+			updatedSettings: { destructiveCommandGuardEnabled: true },
+		})
+
+		expect(ensureDcgInstalled).toHaveBeenCalledWith("/mock/global/storage")
+		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", true)
+		expect(vscode.window.showErrorMessage).not.toHaveBeenCalled()
+	})
+
+	it("disables the setting and reports an installation failure", async () => {
+		vi.mocked(ensureDcgInstalled).mockRejectedValue(new Error("checksum mismatch"))
+
+		await webviewMessageHandler(mockClineProvider, {
+			type: "updateSettings",
+			updatedSettings: { destructiveCommandGuardEnabled: true },
+		})
+
+		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", false)
+		expect(vscode.window.showErrorMessage).toHaveBeenCalledWith(
+			"common:errors.destructive_command_guard_enable_failed",
+		)
+	})
+
+	it("reports non-Error installation failures", async () => {
+		vi.mocked(ensureDcgInstalled).mockRejectedValue("download unavailable")
+
+		await webviewMessageHandler(mockClineProvider, {
+			type: "updateSettings",
+			updatedSettings: { destructiveCommandGuardEnabled: true },
+		})
+
+		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", false)
+		expect(t).toHaveBeenCalledWith("common:errors.destructive_command_guard_enable_failed", {
+			error: "download unavailable",
+		})
+	})
+
+	it("persists disabled state without trying to install", async () => {
+		await webviewMessageHandler(mockClineProvider, {
+			type: "updateSettings",
+			updatedSettings: { destructiveCommandGuardEnabled: false },
+		})
+
+		expect(ensureDcgInstalled).not.toHaveBeenCalled()
+		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", false)
+	})
+})
+
 describe("webviewMessageHandler - terminalProfile", () => {
 	beforeEach(() => {
 		vi.clearAllMocks()

webview-ui/src/components/settings/__tests__/AutoApproveSettings.spec.tsx

@@ -67,6 +67,16 @@ describe("AutoApproveSettings - Save/Discard contract", () => {
 		expectNoImmediateUpdateSettings()
 	})
 
+	it("buffers an allowed command submitted with Enter", () => {
+		const { setCachedStateField } = renderSettings()
+
+		const input = screen.getByTestId("command-input")
+		fireEvent.change(input, { target: { value: "pnpm test" } })
+		fireEvent.keyDown(input, { key: "Enter" })
+
+		expect(setCachedStateField).toHaveBeenCalledWith("allowedCommands", ["pnpm test"])
+	})
+
 	// Case 2: allowedCommands remove
 	it("buffers a removed allowed command without persisting before Save", () => {
 		const { setCachedStateField } = renderSettings({ allowedCommands: ["npm test"] })
@@ -88,6 +98,16 @@ describe("AutoApproveSettings - Save/Discard contract", () => {
 		expectNoImmediateUpdateSettings()
 	})
 
+	it("buffers a denied command submitted with Enter", () => {
+		const { setCachedStateField } = renderSettings()
+
+		const input = screen.getByTestId("denied-command-input")
+		fireEvent.change(input, { target: { value: "sudo rm" } })
+		fireEvent.keyDown(input, { key: "Enter" })
+
+		expect(setCachedStateField).toHaveBeenCalledWith("deniedCommands", ["sudo rm"])
+	})
+
 	// Case 3b: deniedCommands remove
 	it("buffers a removed denied command without persisting before Save", () => {
 		const { setCachedStateField } = renderSettings({ deniedCommands: ["rm -rf"] })