fix(Task): catch updateClineMessage rejections on partial-message paths

The four fire-and-forget updateClineMessage calls in say()/ask()
partial-message branches were void-prefixed without .catch arms. The
callee's webview post is internally guarded, but its synchronous
RooCodeEventName.Message emit can throw via a consumer-attached
listener — so the void sites can produce unhandled rejections.

Replace each `void this.updateClineMessage(...)` with an explicit
.catch arm that logs the error, matching the other rejection-handling
sites in this file. Two new tests pin the say() and ask() catch arms.

Also pin the void on getCheckpointService with a rationale comment:
its top-level try/catch returns undefined on failure, so .catch is
not needed there.

Author: 0xMink

src/core/task/Task.ts

@@ -1197,8 +1197,13 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					// data or one whole message at a time so ignore partial for
 					// saves, and only post parts of partial message instead of
 					// whole array in new listener.
-					/* v8 ignore next -- fire-and-forget webview update; rejection is benign */
-					void this.updateClineMessage(lastMessage)
+					// Fire-and-forget: the webview post is internally guarded, but
+					// the `RooCodeEventName.Message` emit can synchronously throw
+					// if any consumer-attached listener does, which would surface
+					// here as an unhandled rejection. Log it instead.
+					this.updateClineMessage(lastMessage).catch((error) => {
+						console.error("[Task#ask] updateClineMessage failed:", error)
+					})
 					// console.log("Task#ask: current ask promise was ignored (#1)")
 					throw new AskIgnoredError("updating existing partial")
 				} else {
@@ -1239,8 +1244,11 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 						lastMessage.isAnswered = true
 					}
 					await this.saveClineMessages()
-					/* v8 ignore next -- fire-and-forget webview update; rejection is benign */
-					void this.updateClineMessage(lastMessage)
+					// Fire-and-forget: see updateClineMessage call above for the
+					// rationale on the .catch arm.
+					this.updateClineMessage(lastMessage).catch((error) => {
+						console.error("[Task#ask] updateClineMessage failed:", error)
+					})
 				} else {
 					// This is a new and complete message, so add it like normal.
 					this.askResponse = undefined
@@ -1700,8 +1708,10 @@ export class Task extends EventEmitter<TaskEvents> implements TaskLike {
 					lastMessage.images = images
 					lastMessage.partial = partial
 					lastMessage.progressStatus = progressStatus
-					// Fire-and-forget: see updateClineMessage call above for the
-					// rationale on the .catch arm.
+					// Fire-and-forget: webview post is internally guarded, but the
+					// `RooCodeEventName.Message` emit can synchronously throw via a
+					// consumer-attached listener. Surface that as a log, not an
+					// unhandled rejection.
 					this.updateClineMessage(lastMessage).catch((error) => {
 						console.error("[Task#say] updateClineMessage failed:", error)
 					})

src/core/task/__tests__/Task.spec.ts

@@ -2486,7 +2486,7 @@ describe("Cline", () => {
 
 			expect(presentSpy).toHaveBeenCalledTimes(1)
 			const presentErrors = consoleErrorSpy.mock.calls.filter(
-				(call) => typeof call[0] === "string" && call[0].includes("[Task#presentAssistantMessage]"),
+				(call: unknown[]) => typeof call[0] === "string" && call[0].includes("[Task#presentAssistantMessage]"),
 			)
 			expect(presentErrors).toHaveLength(0)
 		})
@@ -2570,10 +2570,83 @@ describe("Cline", () => {
 
 			expect(presentSpy).toHaveBeenCalledTimes(1)
 			const presentErrors = consoleErrorSpy.mock.calls.filter(
-				(call) => typeof call[0] === "string" && call[0].includes("[Task#presentAssistantMessage]"),
+				(call: unknown[]) => typeof call[0] === "string" && call[0].includes("[Task#presentAssistantMessage]"),
 			)
 			expect(presentErrors).toHaveLength(0)
 		})
+
+		it("logs (instead of crashing) when updateClineMessage rejects from the say() partial-update path", async () => {
+			// Pins the symmetric .catch arm on the fire-and-forget
+			// updateClineMessage call in say(). The callee's webview post is
+			// internally guarded, but its synchronous emit can throw via a
+			// consumer-attached listener — that path must surface as a log,
+			// not an unhandled rejection.
+			const boom = new Error("updateClineMessage boom")
+			const updateSpy = vi.spyOn(Task.prototype as any, "updateClineMessage").mockImplementation(async () => {
+				throw boom
+			})
+
+			const task = new Task({
+				provider: mockProvider,
+				apiConfiguration: mockApiConfig,
+				task: "test task",
+				startTask: false,
+			})
+
+			// Seed a prior partial "say" so the partial-update branch fires.
+			task.clineMessages.push({
+				ts: Date.now() - 1,
+				type: "say",
+				say: "text",
+				text: "partial",
+				partial: true,
+			})
+
+			await task.say("text", "updated partial", undefined, true)
+			await flushMicrotasks()
+
+			expect(updateSpy).toHaveBeenCalled()
+			expect(consoleErrorSpy).toHaveBeenCalledWith("[Task#say] updateClineMessage failed:", boom)
+			updateSpy.mockRestore()
+		})
+
+		it("logs (instead of crashing) when updateClineMessage rejects from the ask() complete-partial path", async () => {
+			// Pins the symmetric .catch arm on the fire-and-forget
+			// updateClineMessage call in ask() when finalizing a partial.
+			const boom = new Error("updateClineMessage boom")
+			const updateSpy = vi.spyOn(Task.prototype as any, "updateClineMessage").mockImplementation(async () => {
+				throw boom
+			})
+			const saveSpy = vi.spyOn(Task.prototype as any, "saveClineMessages").mockResolvedValue(true)
+
+			const task = new Task({
+				provider: mockProvider,
+				apiConfiguration: mockApiConfig,
+				task: "test task",
+				startTask: false,
+			})
+
+			// Seed a prior partial "ask" of type "tool" so the complete-partial
+			// branch fires when ask("tool", ..., false) is called.
+			task.clineMessages.push({
+				ts: Date.now() - 1,
+				type: "ask",
+				ask: "tool",
+				text: "partial",
+				partial: true,
+			})
+
+			// ask() resolves only after a response — fire-and-forget so the
+			// promise the suite awaits stays bounded. The .catch on the
+			// pending ask handles the never-resolved promise.
+			void task.ask("tool", "complete", false).catch(() => {})
+			await flushMicrotasks()
+
+			expect(updateSpy).toHaveBeenCalled()
+			expect(consoleErrorSpy).toHaveBeenCalledWith("[Task#ask] updateClineMessage failed:", boom)
+			updateSpy.mockRestore()
+			saveSpy.mockRestore()
+		})
 	})
 })