fix(roo-import): address import state persistence and cleanup

Author: edelauna

apps/vscode-e2e/src/suite/roo-import.test.ts

@@ -36,13 +36,23 @@ suite("Roo Import", function () {
 	setDefaultSuiteTimeout(this)
 
 	let tmpDir: string
+	const importedTaskIds: string[] = []
 
 	suiteSetup(async () => {
 		tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "zoo-e2e-roo-import-"))
 	})
 
 	suiteTeardown(async () => {
 		await fs.rm(tmpDir, { recursive: true, force: true })
+
+		const storagePath = globalThis.api?.storagePath
+		if (storagePath) {
+			await Promise.all(
+				importedTaskIds.map((id) =>
+					fs.rm(path.join(storagePath, "tasks", id), { recursive: true, force: true }),
+				),
+			)
+		}
 	})
 
 	test("importRooHandoff command is registered", async () => {
@@ -61,6 +71,7 @@ suite("Roo Import", function () {
 		const handoffDir = path.join(tmpDir, "handoff")
 		const tasksSource = path.join(handoffDir, "data", "tasks")
 		const taskId = `e2e-test-task-${Date.now()}`
+		importedTaskIds.push(taskId)
 		await fs.mkdir(path.join(tasksSource, taskId), { recursive: true })
 		await fs.writeFile(path.join(tasksSource, taskId, "history_item.json"), JSON.stringify({ id: taskId }))
 
@@ -83,7 +94,7 @@ suite("Roo Import", function () {
 		assert.strictEqual(contents.id, taskId, "Task file content should match what was exported")
 	})
 
-	test("skips import when handoff was already imported", async () => {
+	test("re-runs import with an explicit path without throwing", async () => {
 		const handoffPath = path.join(tmpDir, "handoff-duplicate.json")
 		const createdAt = new Date().toISOString()
 		await fs.writeFile(handoffPath, JSON.stringify(makeHandoff({ createdAt })))

src/activate/__tests__/registerCommands.spec.ts

@@ -127,6 +127,14 @@ describe("handleImportRooHandoff", () => {
 		expect(mockProvider.postStateToWebview).not.toHaveBeenCalled()
 	})
 
+	it("does not call postStateToWebview when import fails", async () => {
+		vi.mocked(RooImport.promptAndImportRooHandoff).mockResolvedValue({ success: false, error: "invalid handoff" })
+
+		await handleImportRooHandoff(undefined, mockContext, mockOutputChannel)
+
+		expect(mockProvider.postStateToWebview).not.toHaveBeenCalled()
+	})
+
 	it("logs and returns undefined when the import throws", async () => {
 		vi.mocked(RooImport.importRooHandoffFromPath).mockRejectedValue(new Error("disk full"))
 

src/activate/registerCommands.ts

@@ -85,7 +85,7 @@ export async function handleImportRooHandoff(
 			? await importRooHandoffFromPath(handoffPath, importOptions)
 			: await promptAndImportRooHandoff(importOptions)
 
-		if (result) {
+		if (result?.success) {
 			await visibleProvider.postStateToWebview()
 		}
 

src/services/roo-import/RooImport.ts

@@ -241,11 +241,11 @@ export async function importRooHandoffFromPath(
 
 					const currentProviderName = merged.currentApiConfigName
 					const currentProvider = merged.apiConfigs[currentProviderName]
-					contextProxy.setValue("currentApiConfigName", currentProviderName)
+					await contextProxy.setValue("currentApiConfigName", currentProviderName)
 					if (currentProvider) {
 						await contextProxy.setProviderSettings(currentProvider)
 					}
-					contextProxy.setValue("listApiConfigMeta", await providerSettingsManager.listConfig())
+					await contextProxy.setValue("listApiConfigMeta", await providerSettingsManager.listConfig())
 
 					log("Imported provider profiles")
 				} else {