Merge branch 'feat/managed-binary-infrastructure' into feat/dcg-binary-service

Author: navedmerchant

src/services/managed-binary/__tests__/download.spec.ts

@@ -149,7 +149,14 @@ describe("managed binary downloads", () => {
 		})
 		await new Promise<void>((resolve) => setImmediate(resolve))
 		await new Promise<void>((resolve) => setImmediate(resolve))
+		let resolved = false
+		void download.then(() => {
+			resolved = true
+		})
 		output.emit("finish")
+		await Promise.resolve()
+		expect(resolved).toBe(false)
+		output.emit("close")
 		await download
 
 		expect(mockGet).toHaveBeenNthCalledWith(2, "https://github.com/asset", expect.any(Function))

src/services/managed-binary/archive.ts

@@ -112,9 +112,17 @@ export async function extractSingleFileTarXzArchive(
 		.split(/\r?\n/)
 		.map((entry) => entry.trim())
 		.filter(Boolean)
+	if (entries.length !== 1) {
+		throw new Error(`${archiveName} archive has an unexpected layout`)
+	}
 	const archiveEntry = entries[0]
 	const entryName = archiveEntry?.split(/\s+/).at(-1)
-	if (entries.length !== 1 || !archiveEntry.startsWith("-") || entryName?.replace(/^\.\//, "") !== expectedFile) {
+	if (
+		!archiveEntry ||
+		!entryName ||
+		!archiveEntry.startsWith("-") ||
+		entryName.replace(/^\.\//, "") !== expectedFile
+	) {
 		throw new Error(`${archiveName} archive has an unexpected layout`)
 	}
 

src/services/managed-binary/download.ts

@@ -144,10 +144,8 @@ function downloadBinaryFileWithRedirects(
 			})
 			response.on("error", abort)
 			response.pipe(output)
-			output.on("finish", () => {
-				output.close()
-				resolve()
-			})
+			output.on("finish", () => output.close())
+			output.on("close", resolve)
 			output.on("error", abort)
 		})