fix: clarify DCG enablement errors

Author: navedmerchant

src/core/webview/__tests__/webviewMessageHandler.spec.ts

@@ -1130,7 +1130,7 @@ describe("webviewMessageHandler - destructiveCommandGuardEnabled", () => {
 
 		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", false)
 		expect(vscode.window.showErrorMessage).toHaveBeenCalledWith(
-			"common:errors.destructive_command_guard_enable_failed",
+			"common:errors.destructiveCommandGuard.enableFailed",
 		)
 	})
 
@@ -1143,12 +1143,9 @@ describe("webviewMessageHandler - destructiveCommandGuardEnabled", () => {
 		})
 
 		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", false)
-		expect(t).toHaveBeenCalledWith("common:errors.destructive_command_guard_enable_failed", {
-			error: "common:errors.destructiveCommandGuard.unavailable",
-		})
-		expect(vscode.window.showErrorMessage).toHaveBeenCalledWith(
-			"common:errors.destructive_command_guard_enable_failed",
-		)
+		expect(t).toHaveBeenCalledWith("common:errors.destructiveCommandGuard.unavailable")
+		expect(vscode.window.showErrorMessage).toHaveBeenCalledWith("common:errors.destructiveCommandGuard.unavailable")
+		expect(t).not.toHaveBeenCalledWith("common:errors.destructiveCommandGuard.enableFailed", expect.anything())
 	})
 
 	it("reports non-Error installation failures", async () => {
@@ -1160,7 +1157,7 @@ describe("webviewMessageHandler - destructiveCommandGuardEnabled", () => {
 		})
 
 		expect(mockClineProvider.contextProxy.setValue).toHaveBeenCalledWith("destructiveCommandGuardEnabled", false)
-		expect(t).toHaveBeenCalledWith("common:errors.destructive_command_guard_enable_failed", {
+		expect(t).toHaveBeenCalledWith("common:errors.destructiveCommandGuard.enableFailed", {
 			error: "download unavailable",
 		})
 	})

src/core/webview/webviewMessageHandler.ts

@@ -686,12 +686,13 @@ export const webviewMessageHandler = async (
 						const { ensureDcgInstalled } = await import("../../services/destructive-command-guard")
 						const binaryPath = await ensureDcgInstalled(provider.context.globalStorageUri.fsPath)
 						if (!binaryPath) {
-							throw new Error(t("common:errors.destructiveCommandGuard.unavailable"))
+							message.updatedSettings.destructiveCommandGuardEnabled = false
+							vscode.window.showErrorMessage(t("common:errors.destructiveCommandGuard.unavailable"))
 						}
 					} catch (error) {
 						message.updatedSettings.destructiveCommandGuardEnabled = false
 						vscode.window.showErrorMessage(
-							t("common:errors.destructive_command_guard_enable_failed", {
+							t("common:errors.destructiveCommandGuard.enableFailed", {
 								error: error instanceof Error ? error.message : String(error),
 							}),
 						)

src/i18n/locales/ca/common.json

@@ -73,9 +73,9 @@
 		"url_fetch_error_with_url": "Error fetching content for {{url}}: {{error}}",
 		"command_timeout": "Command execution timed out after {{seconds}} seconds",
 		"destructiveCommandGuard": {
-			"unavailable": "Destructive Command Guard is enabled but is not available for this platform"
+			"unavailable": "Destructive Command Guard is enabled but is not available for this platform",
+			"enableFailed": "Unable to enable Destructive Command Guard: {{error}}"
 		},
-		"destructive_command_guard_enable_failed": "Unable to enable Destructive Command Guard: {{error}}",
 		"share_task_failed": "Failed to share task. Please try again.",
 		"share_no_active_task": "No active task to share",
 		"share_auth_required": "Authentication required. Please sign in to share tasks.",