feat(TaskRegistry): introduce TaskRegistry and migrate clineStack (#1014)

* feat(TaskRegistry): introduce TaskRegistry and migrate clineStack

* refactor(tests): replace `as any` casts with bracket notation for private member access

* chore(eslint): enforce no-explicit-any with bulk suppressions for existing violations

* docs(TaskRegistry): push method

* fixup! chore(eslint): enforce no-explicit-any with bulk suppressions for existing violations

Author: edelauna

packages/config-eslint/base.js

@@ -2,8 +2,6 @@ import js from "@eslint/js"
 import eslintConfigPrettier from "eslint-config-prettier"
 import turboPlugin from "eslint-plugin-turbo"
 import tseslint from "typescript-eslint"
-import onlyWarn from "eslint-plugin-only-warn"
-
 /**
  * A shared ESLint configuration for the repository.
  *
@@ -21,11 +19,6 @@ export const config = [
 			"turbo/no-undeclared-env-vars": "off",
 		},
 	},
-	{
-		plugins: {
-			onlyWarn,
-		},
-	},
 	{
 		ignores: ["dist/**"],
 	},

packages/config-eslint/package.json

@@ -12,7 +12,6 @@
 		"@next/eslint-plugin-next": "15.5.20",
 		"eslint": "9.39.4",
 		"eslint-config-prettier": "10.1.8",
-		"eslint-plugin-only-warn": "1.2.1",
 		"eslint-plugin-react": "7.37.5",
 		"eslint-plugin-react-hooks": "5.2.0",
 		"eslint-plugin-turbo": "2.10.0",

pnpm-lock.yaml

@@ -1,21 +1,55 @@
 import { ClineProvider } from "../../core/webview/ClineProvider"
+import { TaskRegistry } from "../../core/task/TaskRegistry"
+import { type Task } from "../../core/task/Task"
+
+type ProviderStubFields = {
+	delegationTransitionLocks?: Map<string, Promise<void>>
+	cancelledDelegationChildIds?: Set<string>
+	log?: ReturnType<typeof vi.fn>
+	taskHistoryStore?: { get: (id: string) => unknown }
+	taskRegistry?: TaskRegistry
+	clineStack?: Task[]
+	tasks?: Task[]
+	runDelegationTransition?: unknown
+	removeClineFromStack?: unknown
+	evictCurrentTask?: unknown
+}
+
+type PrivateProviderMethods = {
+	runDelegationTransition: (this: unknown, ...args: unknown[]) => unknown
+	removeClineFromStack: (this: unknown, ...args: unknown[]) => unknown
+	evictCurrentTask: (this: unknown, ...args: unknown[]) => unknown
+}
 
 /**
  * Augments a plain stub object with the instance fields and bound methods that
  * ClineProvider methods read from `this` (runDelegationTransition,
  * delegationTransitionLocks, cancelledDelegationChildIds, cancellingDelegationChildIds),
- * so tests can call private methods via `(ClineProvider.prototype as any).method.call(stub, …)`
+ * so tests can call private ClineProvider methods against a plain object
  * without instantiating a real ClineProvider.
+ *
+ * Pass `tasks` (array of Task mocks) to pre-seed the registry in stack order.
+ * The legacy `clineStack` key is accepted and converted automatically.
  */
-export function makeProviderStub<T extends object>(stub: T): T {
-	const s = stub as any
-	const proto = ClineProvider.prototype as any
+export function makeProviderStub<T extends object>(stub: T): ClineProvider {
+	const s = stub as T & ProviderStubFields
+	const proto = ClineProvider.prototype as unknown as PrivateProviderMethods
 	s.delegationTransitionLocks ??= new Map()
 	s.cancelledDelegationChildIds ??= new Set()
 	s.log ??= vi.fn()
 	s.taskHistoryStore ??= { get: () => undefined }
-	s.runDelegationTransition = proto.runDelegationTransition.bind(s)
+
+	// Convert legacy clineStack array into a TaskRegistry
+	if (!s.taskRegistry) {
+		const registry = new TaskRegistry()
+		const seed: Task[] = s.clineStack ?? s.tasks ?? []
+		for (const t of seed) registry.push(t)
+		s.taskRegistry = registry
+	}
+	delete s.clineStack
+
+	s.runDelegationTransition ??= proto.runDelegationTransition.bind(s)
 	s.removeClineFromStack ??= proto.removeClineFromStack.bind(s)
 	s.evictCurrentTask ??= proto.evictCurrentTask.bind(s)
-	return s
+	return s as unknown as ClineProvider
 }